Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar bottom inset for iPhone X devices #1273

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Fix toolbar bottom inset for iPhone X devices #1273

merged 2 commits into from
Aug 8, 2019

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Aug 8, 2019

Fixes WordPress/gutenberg#16677 (comment)

To test:

  • Try booting the demo app on an iPhone 6 and an iPhone X (or Xs)
  • Notice the problem in the aforementioned comment is gone

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.
    ^ Should not be a problem since the bug was never merged to master.

@Tug Tug added this to the 1.12 milestone Aug 8, 2019
@Tug Tug requested a review from etoledom August 8, 2019 10:05
@Tug Tug self-assigned this Aug 8, 2019
@Tug Tug mentioned this pull request Aug 8, 2019
Merged
5 tasks
etoledom
etoledom approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#16961 (review)

@etoledom etoledom mentioned this pull request Aug 8, 2019
Closed
1 task
@Tug Tug merged commit 9ef5ebd into develop Aug 8, 2019
@Tug Tug deleted the fix/toolbar-bottom-inset branch August 8, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @etoledom