[RNMobile] floating toolbar disappear mechanism #17466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dratwas
requested review from
ellatrix,
talldan and
youknowriad
as code owners
gziolo
added
the
Mobile App - i.e. Android or iOS
|
Thank you for the effort! I don't think we'll need this any soon with the new version of floating toolbar. So I am closing this. We can re-open once we have the ideal solution. |
|
Hi @pinarol 👋 |
|
@mkevins closed already 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged after - #17399
Description
This PR implements a mechanism for hiding floating toolbar - wordpress-mobile/gutenberg-mobile#1318
How has this been tested?
Add a group block with some blocks inside.
Navigate between them and check if the toolbar disappears
Screenshots
Types of changes
New feature
Checklist: