Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Adjust FloatingToolbar to first shippable temporary version #17811

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Oct 7, 2019

Description

Fixes: wordpress-mobile/gutenberg-mobile#1413
Ref to gb-mobile repo: wordpress-mobile/gutenberg-mobile#1419

How has this been tested?

Tested on both platforms:

  1. Add a Group
  2. Add any block inside a Group
  3. Notice the FloatingToolbar

Screenshots

Will be added soon. --> added below.

Types of changes

Render FloatingToolbar over the item but without overlapping.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@lukewalczak
Copy link
Member Author

@pinarol @iamthomasbishop for testing purpose I've merged locally @jbinda changes from branch rnmobile/navigate-down (keep in mind that his PR is still in progress) to present you how FloatingToolbar is going to look like and behave with borders.

screenshot gif
Screenshot 2019-10-08 at 14 42 42

Please let me know if you need more gifs/screenshots etc. Thanks!

@pinarol pinarol added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Feedback Needs general design feedback. labels Oct 8, 2019
@iamthomasbishop
Copy link

This looks pretty good for the first temp. version. One small request before we ship: can we add 8px (or 4px if this is 8 much) margin above/below the floating toolbar?

I have the previously-discussed concerns about spacing/margins but I'm guessing we'll tackle that separately.

@lukewalczak
Copy link
Member Author

@iamthomasbishop Thanks for feedback! I've added margin-bottom: 8px to FloatingToolbar

Screenshot 2019-10-09 at 10 53 13

@iamthomasbishop
Copy link

Awesome, looking good and thank you!

@lukewalczak
Copy link
Member Author

Closing - Functionality was move into the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatingToolbar 1st shippable version
4 participants