-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Adjust FloatingToolbar to first shippable temporary version #17811
[RNMobile] Adjust FloatingToolbar to first shippable temporary version #17811
Conversation
@pinarol @iamthomasbishop for testing purpose I've merged locally @jbinda changes from branch
Please let me know if you need more gifs/screenshots etc. Thanks! |
This looks pretty good for the first temp. version. One small request before we ship: can we add 8px (or 4px if this is 8 much) margin above/below the floating toolbar? I have the previously-discussed concerns about spacing/margins but I'm guessing we'll tackle that separately. |
@iamthomasbishop Thanks for feedback! I've added |
Awesome, looking good and thank you! |
packages/block-editor/src/components/block-list/block-mobile-floating-toolbar.native.js
Outdated
Show resolved
Hide resolved
Closing - Functionality was move into the PR. |
Description
Fixes: wordpress-mobile/gutenberg-mobile#1413
Ref to gb-mobile repo: wordpress-mobile/gutenberg-mobile#1419
How has this been tested?
Tested on both platforms:
Group
Group
FloatingToolbar
Screenshots
Will be added soon. --> added below.
Types of changes
Render FloatingToolbar over the item but without overlapping.
Checklist: