Polish font size in inserter, and latest posts #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does two things 1. It normalizes the font sizes to _two_ sizes instead of 3, and assigns them variables. Notably this makes the font size in the inserter larger. 2. It polishes the Latest Posts block a bit. To elaborate on #1, there's a separate PR, #1757, which bumps the font sizes. But this actually makes the sizes larger than they are in most of WordPress. As such, I think that one needs more discussion. In the mean time, this brings the variable cleanup and inserter font size improvements to master before that discussion can conclude.
swissspidy
reviewed
Jul 7, 2017
blocks/library/embed/index.js
Outdated
| @@ -19,6 +19,7 @@ import { registerBlockType, query } from '../../api'; | |||
| import Editable from '../../editable'; | |||
| import BlockControls from '../../block-controls'; | |||
| import BlockAlignmentToolbar from '../../block-alignment-toolbar'; | |||
| import BlockDescription from '../../block-description'; | |||
There was a problem hiding this comment.
This needs be actually used if it's gonna be imported.
There was a problem hiding this comment.
Argh how embarrassing. This was copy/pasta — which I'm not sure how happened. Great catch, thanks for this!
swissspidy
reviewed
Jul 7, 2017
blocks/library/latest-posts/index.js
Outdated
| > | ||
| <Spinner /> |
There was a problem hiding this comment.
According to Travis the indentation is off. One tab missing.
There was a problem hiding this comment.
Weird that my linter didn't catch this. Thank you again. Also, can you tell I'm in need of a vacation? ;)
|
Merging with feedback addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
To elaborate on #1, there's a separate PR, #1757, which bumps the font sizes. But this actually makes the sizes larger than they are in most of WordPress. As such, I think that one needs more discussion.
In the mean time, this brings the variable cleanup and inserter font size improvements to master before that discussion can conclude.