Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ButtonGroup story for Storybook #17884

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Add ButtonGroup story for Storybook #17884

merged 1 commit into from
Oct 10, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 10, 2019

Description

Adds ButtonGroup to StoryBook

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mkaz mkaz added the [Status] In Progress Tracking issues with work in progress label Oct 10, 2019
@gziolo gziolo added the Storybook Storybook and its stories for components label Oct 10, 2019
@epiqueras epiqueras merged commit 1be6c75 into master Oct 10, 2019
@epiqueras epiqueras deleted the add/stories-button-group branch October 10, 2019 16:14
@epiqueras
Copy link
Contributor

Oops, I missed the "In Progress" label, but the changes are solid and we can work on top of them 😄

@mkaz
Copy link
Member Author

mkaz commented Oct 10, 2019

@epiqueras Not a problem, I only put in progress because I wasn't sure if it was all that was needed. 👍

@epiqueras
Copy link
Contributor

We could add more variations with different numbers of buttons.

@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Oct 11, 2019
@mkaz mkaz mentioned this pull request Oct 11, 2019
Merged
@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras approved these changes

@gziolo gziolo gziolo left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Storybook Storybook and its stories for components
Projects
None yet
Milestone
Gutenberg 6.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mkaz @epiqueras @gziolo @youknowriad