Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook: Add margin to ButtonGroup example #17910

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Storybook: Add margin to ButtonGroup example #17910

merged 1 commit into from
Oct 11, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Oct 11, 2019

Description

Fixes margin issue @gziolo noticed in #17884

How has this been tested?

Confirm in Storybook (npm run design-system:dev) that space exists between two buttons

Screenshots

button-group-margin

Types of changes

Storybook.

@mkaz mkaz added the Storybook Storybook and its stories for components label Oct 11, 2019
@mkaz mkaz mentioned this pull request Oct 11, 2019
Merged
5 tasks
epiqueras
epiqueras approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@epiqueras epiqueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this something the ButtonGroup should do though?

@epiqueras epiqueras merged commit ec5fb41 into master Oct 11, 2019
@epiqueras epiqueras deleted the fix/button-group-stories branch October 11, 2019 20:14
@gziolo
Copy link
Member

gziolo commented Oct 14, 2019

Isn't this something the ButtonGroup should do though?

@mapk @jasmussen @davewhitley @ItsJonQ - can you have a look at this example here?

@jasmussen
Copy link
Contributor

Yes, I would say this is for the ButtonGroup to do, by applying CSS to nested Buttons, rather than having an inline style. Once you put a Button inside a ButtonGroup, it's okay for the core behavior of the Button to change in that context.

@youknowriad youknowriad added this to the Gutenberg 6.7 milestone Oct 14, 2019
@gziolo gziolo mentioned this pull request Oct 16, 2019
Closed
8 tasks
@ciampo ciampo mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiqueras epiqueras epiqueras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees
No one assigned
Labels
Storybook Storybook and its stories for components
Projects
None yet
Milestone
Gutenberg 6.7
Development

Successfully merging this pull request may close these issues.
5 participants
@mkaz @gziolo @jasmussen @epiqueras @youknowriad