-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilise gradient theme API's #20107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
ajitbohra,
chrisvanpatten,
mkaz,
TimothyBJacobs and
youknowriad
as code owners
February 7, 2020 20:15
youknowriad
approved these changes
Feb 7, 2020
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Feb 7, 2020
7 tasks
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Feb 10, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. git-svn-id: https://develop.svn.wordpress.org/trunk@47240 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 10, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. git-svn-id: https://develop.svn.wordpress.org/trunk@47240 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 10, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. Built from https://develop.svn.wordpress.org/trunk@47240 git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Feb 10, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. Built from https://develop.svn.wordpress.org/trunk@47240 git-svn-id: https://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
jorgefilipecosta
added
Needs Dev Note
Requires a developer note for a major WordPress release cycle
and removed
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Feb 11, 2020
23 tasks
sikc8000
pushed a commit
to sikc8000/u0_a165-localhost
that referenced
this pull request
Feb 20, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. Built from https://develop.svn.wordpress.org/trunk@47240
miya0001
pushed a commit
to cjk4wp/wordpress
that referenced
this pull request
Feb 20, 2020
This commit includes in the core settings for the gradients theme API stabilized in WordPress/gutenberg#20107, and for the image sizes required for the latest posts feature image WordPress/gutenberg#17151. Props: youknowriad, ryelle. Fixes #49389. git-svn-id: http://develop.svn.wordpress.org/trunk@47240 602fd350-edb4-49c9-b593-d223f7449a82
youknowriad
removed
the
Needs Dev Note
Requires a developer note for a major WordPress release cycle
label
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stabilizes the gradients theme API. And improves the documentation we have for these API's.
How has this been tested?
For each of the code blocks bellow I verified the result was the one described after each code block:
The custom gradient picker is disabled. The gradient palette is changed to the one the theme is setting.
The gradient functionality is tottaly disbaled.
No default gradeints are provided the user can only use the custom gradient picker.