Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Features/Services 01 pattern #20640

Closed
wants to merge 2 commits into from
Closed

Add Features/Services 01 pattern #20640

wants to merge 2 commits into from

Conversation

enriquesanchez
Copy link
Contributor

@enriquesanchez enriquesanchez commented Mar 5, 2020 •
edited
Loading

Adds a Features/Services section block pattern for #20345.

⚠️ Waiting on https://core.trac.wordpress.org/ticket/49580 to update image URL paths.

Screen Shot 2020-03-04 at 18 26 05

<!-- wp:group {"backgroundColor":"very-light-gray","align":"full"} -->
<div class="wp-block-group alignfull has-background"><div class="wp-block-group__inner-container"><!-- wp:columns {"align":"wide"} -->
<div class="wp-block-columns alignwide"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:image {"align":"center","id":317,"width":320,"height":240,"sizeSlug":"large"} -->
<div class="wp-block-image"><figure class="aligncenter size-large is-resized"><img src="https://i1.wp.com/nrqsnchztest.blog/wp-content/uploads/2020/02/meditating.png?fit=640%2C480&amp;ssl=1" alt="" class="wp-image-317" width="320" height="240"/></figure></div>
<!-- /wp:image -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626","fontSize":"large"} -->
<p style="color:#262626" class="has-text-color has-text-align-center has-large-font-size">Feature 01</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626"} -->
<p style="color:#262626" class="has-text-color has-text-align-center">Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.</p>
<!-- /wp:paragraph -->

<!-- wp:spacer {"height":25} -->
<div style="height:25px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:buttons {"align":"center"} -->
<div class="wp-block-buttons aligncenter"><!-- wp:button {"customBackgroundColor":"#262626","borderRadius":2} -->
<div class="wp-block-button"><a class="wp-block-button__link has-background" style="background-color:#262626;border-radius:2px">Call to action 01</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:image {"align":"center","id":319,"width":320,"height":240,"sizeSlug":"large"} -->
<div class="wp-block-image"><figure class="aligncenter size-large is-resized"><img src="https://i1.wp.com/nrqsnchztest.blog/wp-content/uploads/2020/02/reading.png?fit=640%2C480&amp;ssl=1" alt="" class="wp-image-319" width="320" height="240"/></figure></div>
<!-- /wp:image -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626","fontSize":"large"} -->
<p style="color:#262626" class="has-text-color has-text-align-center has-large-font-size">Feature 02</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626"} -->
<p style="color:#262626" class="has-text-color has-text-align-center">Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
<!-- /wp:paragraph -->

<!-- wp:spacer {"height":25} -->
<div style="height:25px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:buttons {"align":"center"} -->
<div class="wp-block-buttons aligncenter"><!-- wp:button {"customBackgroundColor":"#262626","customTextColor":"#ffffff","borderRadius":2,"className":"is-style-fill"} -->
<div class="wp-block-button is-style-fill"><a class="wp-block-button__link has-text-color has-background" style="background-color:#262626;color:#ffffff;border-radius:2px">Call to action 02</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:image {"align":"center","id":322,"width":320,"height":240,"sizeSlug":"large"} -->
<div class="wp-block-image"><figure class="aligncenter size-large is-resized"><img src="https://i2.wp.com/nrqsnchztest.blog/wp-content/uploads/2020/02/unboxing.png?fit=640%2C480&amp;ssl=1" alt="" class="wp-image-322" width="320" height="240"/></figure></div>
<!-- /wp:image -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626","fontSize":"large"} -->
<p style="color:#262626" class="has-text-color has-text-align-center has-large-font-size">Feature 03</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"align":"center","customTextColor":"#262626"} -->
<p style="color:#262626" class="has-text-color has-text-align-center">Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.</p>
<!-- /wp:paragraph -->

<!-- wp:spacer {"height":25} -->
<div style="height:25px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:buttons {"align":"center"} -->
<div class="wp-block-buttons aligncenter"><!-- wp:button {"customBackgroundColor":"#262626","customTextColor":"#ffffff","borderRadius":2} -->
<div class="wp-block-button"><a class="wp-block-button__link has-text-color has-background" style="background-color:#262626;color:#ffffff;border-radius:2px">Call to action 03</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons --></div>
<!-- /wp:column --></div>
<!-- /wp:columns --></div></div>
<!-- /wp:group -->

@enriquesanchez enriquesanchez self-assigned this Mar 5, 2020
@enriquesanchez enriquesanchez added the [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced label Mar 5, 2020
@github-actions
Copy link

github-actions bot commented Mar 5, 2020 •
edited
Loading

Size Change: 0 B

Total Size: 864 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 104 kB 0 B
build/block-editor/style-rtl.css 10.6 kB 0 B
build/block-editor/style.css 10.6 kB 0 B
build/block-library/editor-rtl.css 7.36 kB 0 B
build/block-library/editor.css 7.36 kB 0 B
build/block-library/index.js 115 kB 0 B
build/block-library/style-rtl.css 7.5 kB 0 B
build/block-library/style.css 7.51 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.7 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 5.75 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.3 kB 0 B
build/edit-post/style-rtl.css 8.64 kB 0 B
build/edit-post/style.css 8.64 kB 0 B
build/edit-site/index.js 4.64 kB 0 B
build/edit-site/style-rtl.css 2.48 kB 0 B
build/edit-site/style.css 2.48 kB 0 B
build/edit-widgets/index.js 4.44 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 3.98 kB 0 B
build/editor/style.css 3.98 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.11 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.48 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.3 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@enriquesanchez
Copy link
Contributor Author

Hi @mtias 👋

Wondering if you have any comments about this pattern. I know we decided to go without images for now but I would like to know if you think we can somehow revisit this one or if we should close this PR instead.

@mapk
Copy link
Contributor

mapk commented Apr 9, 2020

I think the 3-column features pattern would be heavily used. @enriquesanchez Can you try this pattern out with gradient squares/circles instead of the images? Let's see what that would look like.

@enriquesanchez
Copy link
Contributor Author

@mapk @mtias here's a revised version of this pattern with the suggested updates:

Screen Shot 2020-04-13 at 14 57 56

I had to use a spacer block inside the groups with background gradients to achieve that height, otherwise they'd all appear very short.

@mapk
Copy link
Contributor

mapk commented Apr 13, 2020

I vote we close this in favor of #20898 and #21135.

@mapk mapk closed this Apr 13, 2020
@aristath aristath deleted the add/features-services01-pattern branch November 10, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@enriquesanchez enriquesanchez

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enriquesanchez @mapk