Site Editor: add block breadcrumb #21274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 863 kB
ℹ️ View Unchanged
|
noahtallen
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Incredible! Looks good to me. I'm not sure if this is possible, but I think it would be cool to change Document to the name of the entity you are editing. For example:
- If you edit the "front-page" template, the breadcrumb would start with
front-page >instead ofdocument. - If you edit the "header" template part, the breadcrumb would start with
header >instead ofdocument. - Instead of showing
template-partin the breadcrumb, show the entity name (e.g.front-page > header > paragraphinstead ofDocument > template-part > paragraph)
I think the breadcrumb might just need updated to use the experimental block label instead of the block name.
But the functionality looks good to me now 👍
I think it would be for edit-site, but I'm not sure if it's needed in post editor and I wanted to avoid making changes there for now. I might open up a follow-up PR for that discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In its present state it's hard for me to determine whether you are inserting blocks in the template part or the surrounding content area due to lack of visual indicators. Adding block breadcrumbs should hopefully make that easier.
How has this been tested?
Navigate to Site Editor and make sure that block breadcrumb works as expected. Check various screen sizes.
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: