-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype a Breadcrumbs block supporting internationalization #1
Comments
OK, so I've tried to use
What's wrong? What files does it actually look for? Let's follow what happens in |
OK. when
When the
How the md5 method works
If
But WordPress needs one .json file per .js file.
Therefore, the files that we need are:
We therefore need the following two lines in
make-json has two additional parameters [--purge] As noted previously see also bobbingwide/oik-i18n#6 (comment) Previous thoughtsAssuming the solution above can be implemented for all my block plugins then these hacks are no longer necessary... We can probably hook into
and fiddle the file back to the one we started with if the |
… than the src so that the md5 value matches the build/index.js we're loading. Ensure the server side rendered strings are localised.
… dev alias for npm start. Add --no-purge to makejson
sb-breadcrumbs-block v0.6.0 is now available. This issue can be closed. |
The purpose of this issue is fourfold:
Miscellaneous Notes
I commented on WP Tavern's post about the new block directory guidelines ( https://wptavern.com/revised-block-directory-guidelines-proposal-updates-wording-but-changes-little-else ) wondering whether or not I could get some single block plugins that use server side rendering accepted into the block directory.
I searched for a Breadcrumbs block and found https://github.com/phpbits/breadcrumbs-block/ but thought it used more code than necessary.
I also found Site Editor: add block breadcrumb WordPress/gutenberg#21274, but soon realised this is for Block breadcrumbs in Full Site Editing, and not a core block called breadcrumbs.
The text was updated successfully, but these errors were encountered: