-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Directory: Remove the author rating when none exist #22184
Conversation
A `0` rating means there have been no reviews submitted, so we can omit this string.
Size Change: +13 B (0%) Total Size: 824 kB
ℹ️ View Unchanged
|
If the author only has 1 block, the average rating should match the rating on the block. I wonder if it provides any value in that scenario as well. |
🤔 It's repetitive, but it doesn't look negative like a 0 rating does. I think we can leave it, and maybe #22149 will do something about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me! Thanks for the PR.
Description
A
0
rating means there have been no reviews submitted, but currently it looks like a negative rating. This removes the rating part of the string in that case.See #17440 & comment
How to test
whatever
streamshare
Screenshots
No reviews:
With reviews: