Remove the utility property from the inserter items objects #22523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Inserter
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
|
Size Change: +1.45 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
|
#5540 (comment) has some background on why this exists. To illustrate, if one registers two blocks like so: registerBlockType( 'acme/product', {
edit() {
return (
<InnerBlocks
// All blocks are allowed in a Product block...
allowedBlocks={ true }
/>
);
},
} );
registerBlockType( 'acme/buy-button', {
// ...but Buy Button *must* be in a Product block
parent: [ 'acme/product' ],
} );Then it's expected that the Buy Button block will appear at the top of the inserter when the user goes to add a block to a Product block. I'm fine with removing |
That's already the case but implemented differently. AFAIK Right now when we have a "parent" we only show its children on the inserter, there's no "Most used blocks" any more which means, utility is useless. |
|
Just tested it locally and you're right! I'm OK with this then 🙂 |
noisysocks
approved these changes
May 25, 2020
|
Minor: Noting the deprecation in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21462
This property was very confusing and was more something the components (since they can evolve and decide to show things differently) should care about and not computed by selectors.
@noisysocks what do you think, I believe you originally implemented this.