[edit-widgets beta] Fix legacy widgets preview #24861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Feature] Widgets Screen
adamziel
requested review from
ajitbohra,
Soean,
spacedmonkey,
talldan,
TimothyBJacobs and
youknowriad
as code owners
adamziel
force-pushed
the
update/fix-legacy-widgets-preview
branch
from
8a73ecb
to
92463cd
Compare
20 tasks
|
Size Change: +195 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
adamziel
commented
Aug 27, 2020
| @@ -5,6 +5,9 @@ | |||
| "widgetClass": { | |||
| "type": "string" | |||
| }, | |||
| "id": { | |||
There was a problem hiding this comment.
I just removed this attribute in another PR, but without it there's no way to send it over through ServerSideRender. In short - we need to have this attribute, but we shouldn't use it :-) A much better solution would be making the server side rendering API less restrictive - custom arguments would be incredibly helpful (and a great follow-up to this PR).
There was a problem hiding this comment.
Can we rename it "widgetId" or something like that. "id" is too generic and can potentially be used for something else that works across blocks like HTML ids. or block ids...
draganescu
reviewed
Aug 27, 2020
There was a problem hiding this comment.
Trying to test this I the error below when trying to add a legacy widget on this branch:
Looking in console the error is:
Uncaught Error: An error occurred while running 'mapSelect': widget is undefined
And the request to index.php?rest_route=%2Fwp%2Fv2%2Ftypes%2Fwidget-areas&context=edit&_locale=user returns 404
Heads up I merged #24855 so this might need a rebase. I hope the above is just my env :O)
noisysocks
reviewed
Aug 28, 2020
| @@ -273,6 +273,60 @@ public function test_get_items_active_sidebar_with_widgets() { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
| @@ -28,6 +28,13 @@ export const getWidgets = createRegistrySelector( ( select ) => () => { | |||
| ); | |||
| } ); | |||
|
|
|||
| export const getWidget = createRegistrySelector( | |||
adamziel
force-pushed
the
update/fix-legacy-widgets-preview
branch
from
92463cd
to
3e7f0c4
Compare
|
I rebased, added a few more changes, and it should work fine now.
It turns out one of the other PRs broke it on master :( This PR now fixes that problem. |
6 tasks
youknowriad
reviewed
Aug 31, 2020
| attributes={ omit( attributes, 'id' ) } | ||
| attributes={ { | ||
| widgetId, | ||
| ...omit( attributes, 'id' ), |
There was a problem hiding this comment.
should this be omit id or widgetid?
youknowriad
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
This is definitely behaving better than master that said I'm still seeing two issues (potentially separate):
- When loading a legacy widget block (using the markee example), the placeholder of the legacy widget block is shown instead of the markee one directly.
- When I make edits and click "preview", the previously saved values are used but not the values I just typed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the problem where previewing an old-style widget in the Block Areas screen results in "Block rendered as empty".
Note that this PR is based on #24855.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: