Fix wp-env start for non-english core sources #24884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
✔️ Firstly, this does successfully install the correct WordPress image for me
✔️ Secondly, this continues correctly adding the config values.
✔️ Finally, this continues working for a default install with no modifications.
Also, the test failures are unrelated, since the RN tests do not rely on wp-env.
| @@ -83,7 +83,7 @@ async function configureWordPress( environment, config, spinner ) { | |||
| // Add quotes around string values to work with multi-word strings better. | |||
| value = typeof value === 'string' ? `"${ value }"` : value; | |||
| setupCommands.push( | |||
| `wp config set ${ key } ${ value }${ | |||
| `wp config set ${ key } ${ value } --anchor="define( 'WP_DEBUG',"${ | |||
There was a problem hiding this comment.
This works for me assuming that WP_DEBUG is always defined :p
noahtallen
changed the title
wp-env start on a non-English WordPress core. fix #22938
noahtallen
added
[Tool] Env
arm-band
added a commit
to arm-band/wp_geidon
that referenced
this pull request
Sep 4, 2020
- `wp-env` を 1.6.0 から 2.0.0 へ
- 英語版以外のコアでも `wp-env start` 最中にエラーでコケなくなった( [#22938](WordPress/gutenberg#22938) -> [#24884](WordPress/gutenberg#24884) )
- これを受けて npm scripts をワンライナー化
- `sample.env`に Browsersync の proxy と port を記載
- Ususama に合わせて変更
- `gulp-notify` のエラーメッセージ出力を追加
- `gulp-watch` から `gulp.watch` に変更
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To specify the
anchorparameter ofwp config settodefine( 'WP_DEBUG',inconfigureWordPress()instead of using the default/* That’s all, stop editing!, because non-English WordPress core doesn't have that line inwp-config-sample.phpand will return errors. This will fix #22938.By the way, I also tested
--anchor="define( 'WP_DEBUG', true );" --placement=after,--anchor="define( 'WP_DEBUG', false );" --placement=after, etc. It inserts values properly to thewp-config.php, but the CLI still returnsError: Could not process the 'wp-config.php' transformation. Reason: Unable to locate placement anchor..I know this might not be the best solution, but it's better to make wp-env work in all environments first.
How has this been tested?
npx wp-env startwith the default.wp-env.jsonnpx wp-env startwith"core": "https://ja.wordpress.org/latest-ja.zip"in.wp-env.jsonnpm run testAll of these returned no warnings and errors, and the front page of WordPress was displayed at http://localhost:8888.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: