Ensure editor footer remains at the bottom of the screen when navigating regions #26533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
General Interface
talldan
changed the title
|
Size Change: +146 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
fix/navigate-regions-causing-layout-issue
branch
from
ccbc89c
to
283c324
Compare
tellthemachines
approved these changes
Oct 30, 2020
|
Looks like it was introduced by @youknowriad when the interface components were added. Quite a big PR though, so not sure if you have any recollection? In the meantime I'll merge this. |
tellthemachines
pushed a commit
that referenced
this pull request
Oct 30, 2020
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Nov 2, 2020
* nest content styles in container for higher specificity (#26487) * Reusable Blocks: Make the number retrieved from the API unlimited (#26486) * Make the number of reusable blocks returned from the API unlimited This is to fix #26352. Having no limit seems like it could be risky, but there are a number of other places in the codebase where all entities are returned in one call to the API, including categories, which could return a similar amount of data to this. * Remove unnecessary quotes to fix lint error. * Fix block inserter WSOD when an empty reusable block exists (#26484) * Latest Posts: Bring back classname on post list (#26477) * [Heading Block] Fix double alignment controls in toolbar (#26492) * fix heading alignments * add proper supports in deprecation * update all previous deprecations * regenerate fixtures for heading * change migration call * remove previous className + revert saves * Revert "regenerate fixtures for heading" This reverts commit 27af8c3. * change fixtures * create new fixtures + fix deprecation save * address review feedback * URLInput: Use debounce() instead of throttle() (#26529) Wait until the user finishes typing before sending an AJAX request. This ensures that there isn't an AJAX request sent every 200 ms while the user is typing. * Fix single column block display for smaller screens. (#26438) If there is only one column, don't force a 50% flex-basis for small screens. * Fix incorrectly pluralised strings (#26565) * Change block mover label i18n * Update remove block i18n * Ensure footer remains position fixed when navigating regions (#26533) * Update package-lock file to ensure static analysis task passes (#26528) * Removes extra fullstop (#26586) Co-authored-by: Addison Stavlo <Stavz01@gmail.com> Co-authored-by: Paul Bunkham <paul@dobit.co.uk> Co-authored-by: Noah Allen <noahtallen@gmail.com> Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Aaron D. Campbell <aaron@AaronDCampbell.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Tammie Lister <tammie@automattic.com>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26532
When using Ctrl + ` to navigate regions, the footer suddenly takes up more than half the screen on desktop sized browsers.
It's caused by
position: relativebeing applied to regions:gutenberg/packages/components/src/higher-order/navigate-regions/style.scss
Line 2 in 5060734
The footer uses
position: fixedto stick to the bottom of the screen, sorelativesuddenly overrides that.The two potential solutions are:
position: relativefrom navigate regionsposition: relativejust for the footer.I've gone with the second solution as I don't know what implications the first might have.
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: