Backports for 5.6 Beta 3 #26588
Merged
Backports for 5.6 Beta 3 #26588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6486) * Make the number of reusable blocks returned from the API unlimited This is to fix #26352. Having no limit seems like it could be risky, but there are a number of other places in the codebase where all entities are returned in one call to the API, including categories, which could return a similar amount of data to this. * Remove unnecessary quotes to fix lint error.
* fix heading alignments * add proper supports in deprecation * update all previous deprecations * regenerate fixtures for heading * change migration call * remove previous className + revert saves * Revert "regenerate fixtures for heading" This reverts commit 27af8c3. * change fixtures * create new fixtures + fix deprecation save * address review feedback
Wait until the user finishes typing before sending an AJAX request. This ensures that there isn't an AJAX request sent every 200 ms while the user is typing.
If there is only one column, don't force a 50% flex-basis for small screens.
* Change block mover label i18n * Update remove block i18n
tellthemachines
requested review from
ajitbohra,
ellatrix,
nerrad,
ntwb,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +297 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
The tests seem to pass fine locally, so I'm unsure about the failures, especially the Adding Patterns one, which doesn't happen in master.
The changes are pretty straightforward and there doesn't seem to be anything that would cause an issue with those tests, so approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included:
Nest content styles in container for higher specificity (#26487)
Reusable Blocks: Make the number retrieved from the API unlimited (#26486 )
Fix block inserter WSOD when an empty reusable block exists (#26484)
Latest Posts: Bring back classname on post list (#26477)
[Heading Block] Fix double alignment controls in toolbar (#26492)
URLInput: Use debounce() instead of throttle() (#26529)
Fix single column block display for smaller screens. (#26438)
Fix incorrectly pluralised strings (#26565)
Ensure footer remains position fixed when navigating regions (#26533)
Removes extra fullstop (#26586)
How has this been tested?
Screenshots
Types of changes
Checklist: