Provide a minimum of code wrapping for the code block. #26623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +42 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
kjellr
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
I think this seems fine to include. As noted over here, the latest two default themes provide code to wrap this on the front end by default.
The most important thing is just making sure that the front-end matches the back end here. This helps with that.
ZebulanStanphill
added
[Block] Code
|
Thank you Kjell! Now if only I could get the checks to pass :) |
jasmussen
force-pushed
the
try/wrap-code-block
branch
from
81cdb0d
to
a88bbb8
Compare
jasmussen
force-pushed
the
try/wrap-code-block
branch
from
a88bbb8
to
f7f4226
Compare
|
Is this a bug fix? Does it happen on Core too? Should we backport it to WP 5.6 ? |
|
Yes, I think it's worth backporting. It fixes an unintended change to how the code block displays in the editor (and syncs up the front-end styles too, which turned out to be a longstanding issue). |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Nov 30, 2020
Merged
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Dec 1, 2020
* Provide a minimum of code wrapping for the code block. (#26623) * Block Support: Fix font size style when applying block support (#26762) * Fix Separator editor styles (#27071) * Fix the Post author selector for contributors (#26554) Co-authored-by: Riad Benguella <benguella@gmail.com> * Align single half width column to left (#27142) * remove the auto margin for individual column blocks * update margin values for blocks in blocks to zero insted of auto * Add backward compatibility support for lightBlockWrapper in getSaveElement (#27189) * Code block: paste plain text (#27236) * paste plain text option * Add e2e test * Fix crash when null date passed to TimePicker (#27316) * Fix crash when null date passed. * Update test * Fix GH actions "cancel" step (#27025) * use new syntax for setting env var * Update package-lock * Update package-lock again * Remove the button only option from the UI until it can be wired up to something that works in the front end. (#27379) * Fix combobox csuggestion list closure when clicking scrollbar (#27367) Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: andrei draganescu <me@andreidraganescu.info> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Noah Allen <noahtallen@gmail.com> Co-authored-by: Andy Peatling <apeatling@users.noreply.github.com>
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26600.
I'm not entirely sure what might have caused this, but #26600 suggests that a recent change casued text in the code block to stop wrapping. I'm not sure what that might be, the only recent change is #26347 and that doesn't look like it would've caused anything.
But in any case, this PR explicitly allows code to break words and wrap:
Right now it does that in the
style.scssfile which loads for every code block. That's a big opinionated change to the block, so it needs a bit sanity check.On the flipside, if we move those rules to
theme.scss, very few themes will actually benefit from this change. But I'm happy to do so if that's desired. Let me know your thoughts!