Switch back to getAuthors #26554

adamsilverstein · 2020-10-28T22:43:38Z

Description

Fixes #26476

How has this been tested?

Screenshots

Types of changes

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.
I've included developer documentation if appropriate.
I've updated all React Native files affected by any refactorings/renamings in this PR.

youknowriad · 2020-10-30T07:39:10Z

packages/core-data/src/resolvers.js

+	const users = yield apiFetch( {
+		path: `/wp/v2/users?who=authors&include=${ id }`,
+	} );
+	yield receiveUserQuery( 'author', users );


should the first argument here be "authors" to match the same entity as "getAuthors"?

Maybe? I think that results in the fetched author overwriting the authors? I can test.

Tested changing this and confirmed using the same key results in the query interfering with the getAuthors query, causing errors or unexpected results as the results from the two queries overwrite each other.

Mmm, so if I'm reading this right getAuthor(1) and getAuthor(2) are using the same query key which means if I trigger both concurrently, they'll mess with each other's result.

@youknowriad - Oh, good point. I didn't think about concurrent requests. Should we build a dynamic key here that includes the requested id? Do we have an existing component that uses this approach/a helper to create the query key?

Yes, I did add dynamic query keys for both getAuthor and getAuthors, I think it will solve both issues so I reverted the change you did with useMemo

youknowriad · 2020-11-03T05:07:02Z

packages/editor/src/components/post-author/index.js

-			const author = getUser( getEditedPostAttribute( 'author' ) );
+			const author =
+				postAuthor ||
+				__unstableGetAuthor( getEditedPostAttribute( 'author' ) )[ 0 ];


Actually, why do we need [ 0 ] here. getAuthor only returns one author right?

Yes, but it is returned as an array with a single element. I can change this so __unstableGetAuthor returns a single element which makes more sense based on the naming, does that sound good?

youknowriad · 2020-11-03T05:07:39Z

Seems like there's some valid test failures.

adamsilverstein · 2020-11-03T14:25:46Z

Seems like there's some valid test failures.

I'll take a look.

adamsilverstein · 2020-11-04T14:46:53Z

Seems like there's some valid test failures.

@youknowriad One issue was the selector was showing even when the site only had one author.

I had removed the check for authors.length <= 1 when switching to getAuthors because the authors in check.js uses the same data store as the selector itself, so when you started searching and got zero results, the authors in the check would also be empty and the selector would disappear!

To alleviate this I added originalAuthors behind a memo call in cead69d (#26554) so it is only set once. What do you think?

youknowriad · 2020-11-09T08:45:19Z

packages/core-data/src/selectors.js

+ */
+export function __unstableGetAuthor( state ) {
+	const authors = getUserQueryResults( state, 'author' );
+	return authors ? authors[ 0 ] : [];


It should probably return null if the author was not found.

Good point, will change.

youknowriad · 2020-11-09T08:47:20Z

the same data store as the selector itself, so when you started searching and got zero results, the authors in the check would also be empty and the selector would disappear!

I think that's the issue, both selectors use different queries, so they shouldn't share the same "query key".

adamsilverstein · 2020-11-13T17:20:17Z

I think that's the issue, both selectors use different queries, so they shouldn't share the same "query key".

Right - that is why I changed the single author query key to 'author' vs 'authors'

youknowriad · 2020-11-16T08:04:25Z

This is looking good for me, but it could use some testing @adamsilverstein

skorasaurus · 2020-11-16T17:26:02Z

Hi,

I tested this out (last commit - f507edb ) on a test site [wordpress 5.5.3] with no other plugins installed except this one and the select author dropdown does not appear, even as an admin user. I created another user with the 'editor' role just to be sure that the author drop down didn't display if there was only one registered user and still had the same result.

tellthemachines · 2020-11-17T01:17:21Z

Tested this branch on top of WP 5.6-beta4 and can confirm the post author dropdown isn't showing for either editor or admin users. The PostAuthor component doesn't seem to be rendering at all now 😕

youknowriad · 2020-11-17T07:20:13Z

Yep, i just realized I forgot to fix the query key in the selector.😅

skorasaurus · 2020-11-17T16:39:31Z

Thanks for the additional fix; with that last commit, I now confirm that the postauthor component now displays as intended and is keyboard accessible as well.

adamsilverstein · 2020-11-18T23:30:54Z

@youknowriad - Great! Works well in my testing.

adamsilverstein

👍 Looks good!

Co-authored-by: Riad Benguella <benguella@gmail.com>

* Provide a minimum of code wrapping for the code block. (#26623) * Block Support: Fix font size style when applying block support (#26762) * Fix Separator editor styles (#27071) * Fix the Post author selector for contributors (#26554) Co-authored-by: Riad Benguella <benguella@gmail.com> * Align single half width column to left (#27142) * remove the auto margin for individual column blocks * update margin values for blocks in blocks to zero insted of auto * Add backward compatibility support for lightBlockWrapper in getSaveElement (#27189) * Code block: paste plain text (#27236) * paste plain text option * Add e2e test * Fix crash when null date passed to TimePicker (#27316) * Fix crash when null date passed. * Update test * Fix GH actions "cancel" step (#27025) * use new syntax for setting env var * Update package-lock * Update package-lock again * Remove the button only option from the UI until it can be wired up to something that works in the front end. (#27379) * Fix combobox csuggestion list closure when clicking scrollbar (#27367) Co-authored-by: Joen A <1204802+jasmussen@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Adam Silverstein <adamsilverstein@earthboundhosting.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: andrei draganescu <me@andreidraganescu.info> Co-authored-by: Daniel Richards <daniel.richards@automattic.com> Co-authored-by: Ella van Durpe <wp@iseulde.com> Co-authored-by: Noah Allen <noahtallen@gmail.com> Co-authored-by: Andy Peatling <apeatling@users.noreply.github.com>

Switch back to getAuthors

d4c49cf

adamsilverstein mentioned this pull request Oct 28, 2020

New authors dropdown breaks author selection for editors #26476

Closed

adamsilverstein added 4 commits October 29, 2020 08:12

Use __unstableGetAuthor.

75c7372

Remove deprecated call.

3d4c6f0

Avoid repeated calls to __unstableGetAuthor.

2c0a96a

Improfe request in __unstableGetAuthor.

8b76134

adamsilverstein marked this pull request as ready for review October 29, 2020 21:43

adamsilverstein requested a review from nerrad as a code owner October 29, 2020 21:43

adamsilverstein requested a review from youknowriad October 29, 2020 21:45

youknowriad reviewed Oct 30, 2020

View reviewed changes

youknowriad added [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Oct 30, 2020

youknowriad approved these changes Nov 3, 2020

View reviewed changes

youknowriad reviewed Nov 3, 2020

View reviewed changes

adamsilverstein added 2 commits November 3, 2020 16:54

Merge branch 'master' into fix/26476

5e97f14

Move array extraction into __unstableGetAuthor selector.

6c832c9

adamsilverstein force-pushed the fix/26476 branch from 05d2a9d to 6c832c9 Compare November 4, 2020 00:12

Avoid showing author selector when only one user.

cead69d

youknowriad mentioned this pull request Nov 6, 2020

REST API error when getting users with non-admin role #26747

Closed

youknowriad reviewed Nov 9, 2020

View reviewed changes

youknowriad added 2 commits November 16, 2020 08:58

fix getAuthor and getAuthors resolvers

b6c9de7

simplification

f507edb

Fix small selector issues

d1f0d03

adamsilverstein requested review from ajitbohra, chrisvanpatten and mkaz as code owners November 17, 2020 07:19

adamsilverstein commented Nov 18, 2020

View reviewed changes

youknowriad merged commit 1db8243 into WordPress:master Nov 19, 2020

github-actions bot added this to the Gutenberg 9.5 milestone Nov 19, 2020

tellthemachines pushed a commit that referenced this pull request Nov 30, 2020

Fix the Post author selector for contributors (#26554)

9896f96

Co-authored-by: Riad Benguella <benguella@gmail.com>

tellthemachines mentioned this pull request Nov 30, 2020

Backports for 5.6 RC2 #27366

Merged

6 tasks

tellthemachines removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 1, 2020

obenland mentioned this pull request Jan 29, 2021

Author list in Posts in the Block Editor only shows some of the available authors Automattic/wp-calypso#46536

Open

orenwolf mentioned this pull request Mar 30, 2021

Editors getting a 403 from REST API when attempting to search author list in a post #30360

Closed

swissspidy mentioned this pull request Oct 5, 2021

Core Data: Deprecate getAuthors in favor of getUsers #33725

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch back to getAuthors #26554

Switch back to getAuthors #26554

adamsilverstein commented Oct 28, 2020 •

edited

Loading

youknowriad Oct 30, 2020

adamsilverstein Oct 30, 2020

adamsilverstein Nov 2, 2020

youknowriad Nov 9, 2020

adamsilverstein Nov 13, 2020

youknowriad Nov 16, 2020

youknowriad Nov 3, 2020

adamsilverstein Nov 3, 2020

youknowriad commented Nov 3, 2020

adamsilverstein commented Nov 3, 2020

adamsilverstein commented Nov 4, 2020 •

edited

Loading

youknowriad Nov 9, 2020

adamsilverstein Nov 13, 2020

youknowriad commented Nov 9, 2020

adamsilverstein commented Nov 13, 2020

youknowriad commented Nov 16, 2020

skorasaurus commented Nov 16, 2020 •

edited

Loading

tellthemachines commented Nov 17, 2020

youknowriad commented Nov 17, 2020

skorasaurus commented Nov 17, 2020

adamsilverstein commented Nov 18, 2020

adamsilverstein left a comment

Switch back to getAuthors #26554

Switch back to getAuthors #26554

Conversation

adamsilverstein commented Oct 28, 2020 • edited Loading

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad commented Nov 3, 2020

adamsilverstein commented Nov 3, 2020

adamsilverstein commented Nov 4, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad commented Nov 9, 2020

adamsilverstein commented Nov 13, 2020

youknowriad commented Nov 16, 2020

skorasaurus commented Nov 16, 2020 • edited Loading

tellthemachines commented Nov 17, 2020

youknowriad commented Nov 17, 2020

skorasaurus commented Nov 17, 2020

adamsilverstein commented Nov 18, 2020

adamsilverstein left a comment

Choose a reason for hiding this comment

adamsilverstein commented Oct 28, 2020 •

edited

Loading

adamsilverstein commented Nov 4, 2020 •

edited

Loading

skorasaurus commented Nov 16, 2020 •

edited

Loading