[RNMobile] Audio block UI test #28674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
jd-alexander
commented
Feb 3, 2021
Comment on lines
20
to
24
| if ( isAndroid ) { | ||
| await editorPage.driver.sleep( 5000 ); | ||
| } else { | ||
| await editorPage.driver.sleep( 1000 ); | ||
| } |
There was a problem hiding this comment.
I did this because there was some flakiness in the File Block test when the chooseMediaLibrary option was used below. So I just adapted this here as a precaution. Let me know if that's fine.
There was a problem hiding this comment.
I think there's a typo here and it's always truthy in this case. isAndroid is a function and should be called with isAndroid() instead. Same for the File block, I hope tests won't fail on iOS after fixing this.
There was a problem hiding this comment.
Thanks! I resolved this for the File and Audio Block a1ed719. I will observe the iOS tests to see if they fail or pass and make the necessary modifications to get the code working as expected.
ceyhun
reviewed
Feb 4, 2021
| await editorPage.chooseMediaLibrary(); | ||
|
|
||
| const html = await editorPage.getHtmlContent(); | ||
| expect( testData.audioBlockPlaceholder.toLowerCase() ).toBe( |
There was a problem hiding this comment.
I think I made a mistake converting these expectations lately. It should've been expect(received).toBe(expected) for the diff in case of an error to display correctly.
expect( html... ).toBe(testData...) in this case. Do you think it makes sense to fix other places in this PR as well?
There was a problem hiding this comment.
Makes sense! I resolved this for the File and Audio block since the changes being done in this PR were related to both blocks. I will create another PR for the block tests that need these assertions inverted.
There was a problem hiding this comment.
I created a PR for the rest of the expect matcher fixes here #28770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes involve adding UI tests for the Audio Block component on the mobile version of the editor.
How has this been tested?
CI should be ✅ on wordpress-mobile/gutenberg-mobile#3091
Types of changes
Checklist: