-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio block UI test #3091
Audio block UI test #3091
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@ceyhun I need some advice on this, the id of the audio block is failing on either Android or iOS on the full test suite, and the id difference is by 1. I am not sure what's causing this. |
@jd-alexander I think I found where it came from.
I think it could be better to set Android one to 5 because another media with id=4 already exists on iOS 😄 |
You have such a good eye. I just remembered that those were declared as such. Thanks @ceyhun 😬 |
Removed submodule gutenberg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via WordPress/gutenberg#28674
gutenberg PR WordPress/gutenberg#28674
This PR updates the gutenberg reference to test the new UI tests for the Audio block.
To test:
CI must be ✅ ( Will be marked as ready for review once tests pass)
PR submission checklist: