Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio block UI test #3091

Merged
merged 7 commits into from
Feb 6, 2021
Merged

Audio block UI test #3091

merged 7 commits into from
Feb 6, 2021

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Feb 2, 2021

gutenberg PR WordPress/gutenberg#28674

This PR updates the gutenberg reference to test the new UI tests for the Audio block.

To test:

CI must be ✅ ( Will be marked as ready for review once tests pass)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@jd-alexander jd-alexander added this to the 1.47 (16.8) milestone Feb 2, 2021
@jd-alexander jd-alexander marked this pull request as draft February 2, 2021 19:53
@jd-alexander jd-alexander marked this pull request as ready for review February 2, 2021 20:55
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 2, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@jd-alexander
Copy link
Contributor Author

jd-alexander commented Feb 2, 2021

@ceyhun I need some advice on this, the id of the audio block is failing on either Android or iOS on the full test suite, and the id difference is by 1. I am not sure what's causing this.

@ceyhun
Copy link
Contributor

ceyhun commented Feb 4, 2021

@ceyhun I need some advice on this, the id of the audio block is failing on either Android or iOS on the full test suite, and the id difference is by 1. I am not sure what's causing this.

@jd-alexander I think I found where it came from.

I think it could be better to set Android one to 5 because another media with id=4 already exists on iOS 😄

@jd-alexander
Copy link
Contributor Author

@ceyhun I need some advice on this, the id of the audio block is failing on either Android or iOS on the full test suite, and the id difference is by 1. I am not sure what's causing this.

@jd-alexander I think I found where it came from.

  • iOS:

https://github.com/WordPress/gutenberg/blob/8cfbfb0c8b184e2dc48299b53a91b0c5b91e5d0c/packages/react-native-editor/ios/GutenbergDemo/GutenbergViewController.swift#L106

  • Android:

https://github.com/WordPress/gutenberg/blob/8cfbfb0c8b184e2dc48299b53a91b0c5b91e5d0c/packages/react-native-editor/android/app/src/main/java/com/gutenberg/MainApplication.java#L88

I think it could be better to set Android one to 5 because another media with id=4 already exists on iOS 😄

You have such a good eye. I just remembered that those were declared as such. Thanks @ceyhun 😬

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-alexander jd-alexander merged commit 4711aec into develop Feb 6, 2021
@jd-alexander jd-alexander deleted the add/audio-block-ui-test branch February 6, 2021 02:48
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks
@ceyhun ceyhun restored the add/audio-block-ui-test branch February 17, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants