Site Editor: remove the "All" panel from the Template navigation sidebar. #28801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiebe
added
the
[Feature] Site Editor
mattwiebe
requested review from
jameskoster,
vindl,
Copons,
david-szabo97,
jeyip and
Addison-Stavlo
|
Size Change: -49 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Looks good - Thanks!
Code wise is good but related tests should be updated before merge, like this one: https://github.com/WordPress/gutenberg/blob/master/packages/e2e-tests/specs/experiments/multi-entity-editing.test.js#L195
jameskoster
approved these changes
Feb 8, 2021
|
@mattwiebe this might no longer be needed after #28291? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the "All" option from the Template panel of the Navigation Sidebar
Fixes #26925
How has this been tested?
Screenshots
Before:
After:
Types of changes
Breaking change (?) - all the other templates are still there.
Checklist: