Site Editor: Browsing sidebar templates menu restructure #28291
Conversation
|
For now, here's what I think we should probably do:
Here's a visual rendition of that:
I'm sure that in the future we can refine the sections, but I think this would be a good place to start. |
david-szabo97
force-pushed
the
update/navigation-panel-menus-restructure
branch
from
6abcd28 to
33ff608
Compare
|
Size Change: +3.12 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
david-szabo97
force-pushed
the
update/navigation-panel-menus-restructure
branch
from
966cca3 to
2779c31
Compare
david-szabo97
added
the
[Feature] Site Editor
david-szabo97
changed the title
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Copons and
Addison-Stavlo
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
|
One thing that tripped me up a bit is the custom It's worth remembering that custom templates can be restricted to specific post types, or made available to a set of post types, including CPTs. [Docs] The Then, the "Page templates" and "Post templates" sections are reserved for templates that target a specific page or post. |
|
Moved |
| } | ||
|
|
||
| if ( | ||
| slug.startsWith( 'post-' ) || |
There was a problem hiding this comment.
Maybe we can isolate these to an array similar to TEMPLATES_TOP_LEVEL?
I'd just noticed it too, but somebody was ahead of us: #29531 |
packages/edit-site/src/components/navigation-sidebar/navigation-panel/template-hierarchy.js
Outdated
Show resolved
Hide resolved
|
One thing that jumped to mind when reviewing is the |
|
Just to clarify why the single-post template was added: Even with updated descriptions, the Single and Singular (in particular) templates are a little ambiguous. I worry that it's a lot to ask of users to understand that the single template will resolve not only for posts, but for any single CPT entries as well. An option to add an explicit template for pages exists, I think it stands to reason that there also be a corresponding option for posts. |
|
It's not a template that is used frequently on themes because "single" covers most of the needs, and any other more specific custom post type gets its own template if needed. Having both "single" and "single-post" is more confusing. We could have the name "Single Post" on |
I think that would help people who are not familiar with the wp template hierarchy. The trade-off is that users will have to exercise some doublethink in order to understand that the "Single Post" template is for single Posts (as in single entries of the |
I agree, I'm fine with removing the As for what to call the "Single" template, I think "Single Post" (or even just "Post" to correspond with the "Page" template nomenclature) seems okay. It is kind of confusing that that template might be used for CPT entries too, but I'm not sure it's more confusing than having the current state of affairs (where the vaguely-named "Single" template does that). |
🤔 "Single Entry", "Single Item"... 🤷♀️ |
Hah, the idea of adding "Post" to the name is to make it intuitive for people to add a template that displays a single blog post. "Single" alone doesn't describe that very well. I suppose the description helps with the doublethink situation a bit?
Having to include that "Or a single post of any other type" bit really bugs me, but I'm struggling to think of an alternative, if we want to get rid of single-post. |
Maybe 'custom' would fit better than 'other' ? At least trying to think as a new user 'custom' seems more like something i dont necessarily need to worry about, but 'other' type might make me a little concerned that I don't know what the other types are! 😆 "Template used to display a single blog post, or a single post of any custom type" |
|
Another idea (probably asking too much here but let's at least rule it out) would be to make the description dynamic, and explicitly list which post types it will resolve for. So if the following public post types exist:
And the following templates exist:
The description for the Single template would read:
If you then deleted the
We might do something similar for the Singular template. |
|
This sounds like a good candidate for a follow-up, what ya'll think? 😄 We can go ahead and merge this if you don't have any blockers here. |
|
I think that's fair. This looks good from the design side. |
|
Sorry for derailing the conversation :) |
Description
home,index,singular) goes to unused menupage-homeis an exception, it's set to shown up in GeneralUnused templates
Q: Why only
home,indexandsingularcan be in the Unused templates menu?We wanted to keep it simple and only primary and secondary templates are moved to Unused menu. Hiding unused templates accurately would be extremely difficult.
Only 3 templates met these conditions:
homemet the conditions because it is considered unused if:front-pagetemplate existsindexmet the conditions because it is considered unused if:archive,404,searchtemplate existsingleandpageexist ORsingularexists)homeexists OR superseded byfront-pageOR custom page shown on front)singularmet the conditions because it is considered unused if:singleandpagetemplate existHow has this been tested?
post-*,author-*,single-post-*,tag-*show up herepage-*show up here$customshows up herehome,index, and/orsingularshows up here if conditions are metScreenshots
Screen.Recording.2021-02-17.at.16.06.23.mov
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: