Site Editor (Experiment): Automatically open the sidebar to the appropriate template sub-menu #30098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Status] In Progress
6 tasks
|
Size Change: +39 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Thanks @Copons this is working as expected now :) I think we'll need to see the outcome of 29630 before merging, but this is in a good spot imo. |
Comment on lines
+33
to
+36
| import { | ||
| getTemplatesLocationMap, | ||
| getUnusedTemplates, | ||
| } from '../template-hierarchy'; |
There was a problem hiding this comment.
Thanks for extracting these!
Comment on lines
+189
to
+211
| const templates = select( coreDataStore ).getEntityRecords( | ||
| 'postType', | ||
| 'wp_template', | ||
| { | ||
| per_page: -1, | ||
| } | ||
| ); | ||
| const showOnFront = select( coreDataStore ).getEditedEntityRecord( | ||
| 'root', | ||
| 'site' | ||
| ).show_on_front; | ||
|
|
||
| if ( | ||
| isTemplateSuperseded( | ||
| template.slug, | ||
| map( templates, 'slug' ), | ||
| showOnFront | ||
| ) | ||
| ) { | ||
| return MENU_TEMPLATES_UNUSED; | ||
| } | ||
|
|
||
| return getTemplateLocation( template.slug ); |
There was a problem hiding this comment.
I really love this 😄 Great use of existing functions!
Copons
force-pushed
the
try/templates-initial-menu
branch
2 times, most recently
from
884913c
to
4829b76
Compare
david-szabo97
approved these changes
Mar 24, 2021
packages/edit-site/src/components/navigation-sidebar/navigation-panel/template-hierarchy.js
Outdated
Show resolved
Hide resolved
Copons
force-pushed
the
try/templates-initial-menu
branch
from
4829b76
to
14bfe0e
Compare
This was referenced May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #26964
The previous PR only took care of Template Parts, as they are arguably easier to handle.
Their sub-menu location is explicitly contained by their post objects, so there's not much to figure out.
Templates locations, on the other hand, depend on other templates as well.
While most commonly templates will belong to a precise location as defined in the Navigation Panel constants, at times a template might be superseded by another (e.g.
front-pagesupersedeshome), and end up grouped in their own "Unused" sub-menu.Most of the groundwork was already laid down in #28291, by creating specific helper functions for the menu rendering.
This PR takes those functions and moves them into the
template-hierarchy.jsutilities file, to share them with thegetCurrentTemplateNavigationPanelSubMenuselector introduced in the previous PR.NOTE: I'm not overly happy with how I've handled this move, and I think I can do better.
How has this been tested?
Screenshots
Types of changes
Checklist: