[RNMobile] Enable Embed block in dev mode #30456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.09 kB (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
2 tasks
ceyhun
added
the
Mobile App - i.e. Android or iOS
jd-alexander
reviewed
Apr 7, 2021
jd-alexander
reviewed
Apr 7, 2021
|
@ceyhun I was taking a look at the Android test but I haven't quite figured out why it's failing. I will take another look tomorrow. |
Managed to reproduce this locally, seems like it's related to the newly added embed block code in the initial-html. I'll try to find what part is exactly causing the issue. |
This reverts commit 4381c39.
@jd-alexander I found out that after |
jd-alexander
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables Embed block in dev mode on mobile
How has this been tested?
See: wordpress-mobile/gutenberg-mobile#3331
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).