Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generic Embed block in dev mode #3331

Merged
merged 7 commits into from
Apr 13, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Apr 1, 2021

Fixes #3272

gutenberg PR: WordPress/gutenberg#30456

To test:

In dev mode:

  • Check if block inserter list has only the generic Embed block (and not the ones like Youtube, Twitter, etc.)
  • Try adding a generic Embed block via the inserter
  • Check if Embed block is rendering in initial html in the demo app without crashing

In release mode:
Can be tested using:
WPiOS PR: wordpress-mobile/WordPress-iOS#16214
WPAndroid PR: wordpress-mobile/WordPress-Android#14388

  • The block inserter shouldn't show Embed block
  • If a post already has an Embed block, it should be shown as unsupported

On web:

  • Check if Embed block is still working without any errors (can be rendered, added, modified)

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ceyhun ceyhun enabled auto-merge April 13, 2021 08:16
@ceyhun ceyhun merged commit 35a776f into develop Apr 13, 2021
@ceyhun ceyhun deleted the add/3272-enable-embed-block-in-dev branch April 13, 2021 08:43
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Embed block] Show generic Embed Block in block list in DEV mode
2 participants