Blocks: Restore freeform block toolbar z-index #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Oct 31, 2017
| @return map-get( $z-layers, $key ); | ||
| } | ||
|
|
||
| @error "Error: Specified z-index `#{$key}` does not exist in the mapping"; |
youknowriad
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where the freeform block floating toolbar could not be clicked when overlapping content. The freeform block toolbar inherited
z-indexfrom the block toolbar which was removed as part of #2998. It is unclear whether the freeform block toolbar should be moved to the header as well, but in the interim this resolves the layering issues. Further, it introduces a change to surfacez-indexfunction unmatched references by failing the build when attempting to use a key which is not defined.Testing instructions:
Verify that there are no errors in Gutenberg build.