-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing period in block descriptions. #32838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
Concurrently these seem to have moved to the block.json file in #31120.
I noticed some of the descriptions have been fixed in that PR, so it might be worth checking this is still required.
@@ -14,7 +14,7 @@ const { name } = metadata; | |||
export { metadata, name }; | |||
|
|||
export const settings = { | |||
title: __( 'Post Hierarchical Terms' ), | |||
title: __( 'Post Hierarchical Terms.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the block title.
@audrasjb, it looks like you need to rebase your fork with the |
I have checked the description in all block.json in the latest trunk. Periods are missing in the following two blocks:
It might be a good idea to rebase this PR and apply the appropriate changes again. |
I have created a valid #57131 for the latest trunk, so I would like to close this PR. |
Description
In the few recent blocks added in last versions of the block editor, some block descriptions were missing a final period. This pull request fix this small consistency issue.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).