Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing period in block descriptions. #32838

Closed

Conversation

audrasjb
Copy link
Contributor

Description

In the few recent blocks added in last versions of the block editor, some block descriptions were missing a final period. This pull request fix this small consistency issue.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • [] My code has proper inline documentation.
  • [] I've included developer documentation if appropriate.
  • [] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@audrasjb audrasjb requested a review from ajitbohra as a code owner June 20, 2021 17:22
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Concurrently these seem to have moved to the block.json file in #31120.

I noticed some of the descriptions have been fixed in that PR, so it might be worth checking this is still required.

@@ -14,7 +14,7 @@ const { name } = metadata;
export { metadata, name };

export const settings = {
title: __( 'Post Hierarchical Terms' ),
title: __( 'Post Hierarchical Terms.' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the block title.

@gziolo
Copy link
Member

gziolo commented Jun 22, 2021

@audrasjb, it looks like you need to rebase your fork with the trunk from the upstream repository. As far as I can tell, all descriptions end with the period after my update when moving to block.json.

@gziolo gziolo added [Type] Copy Issues or PRs that need copy editing assistance [Package] Block library /packages/block-library labels Jun 22, 2021
@t-hamano
Copy link
Contributor

I have checked the description in all block.json in the latest trunk. Periods are missing in the following two blocks:

"description": "Displays a title with the number of comments",

"description": "Displays a list of page numbers for pagination",

It might be a good idea to rebase this PR and apply the appropriate changes again.

@Mamaduka
Copy link
Member

I can confirm that only blocks mentioned by @t-hamano are missing periods.

@audrasjb, it might be easier to open a new PR to fix the issue.

@t-hamano
Copy link
Contributor

I have created a valid #57131 for the latest trunk, so I would like to close this PR.

@t-hamano t-hamano closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants