Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing period in block descriptions #57131

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Add missing period in block descriptions #57131

merged 1 commit into from
Dec 17, 2023

Conversation

t-hamano
Copy link
Contributor

Alternative to #32838

What?

Unify block descriptions to end with a period.

@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 16, 2023
@t-hamano t-hamano self-assigned this Dec 16, 2023
@t-hamano t-hamano mentioned this pull request Dec 16, 2023
Closed
4 tasks
@t-hamano t-hamano added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label Dec 16, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2023 •
edited
Loading

Flaky tests detected in a056a80.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7229486583
📝 Reported issues:

@t-hamano t-hamano force-pushed the quality/block-description-period branch 2 times, most recently from 7abf634 to f739ed1 Compare December 16, 2023 03:10
@t-hamano @audrasjb
Add missing period in block descriptions.
a056a80 
Co-authored-by: Jb Audras <audrasjb@gmail.com>
@t-hamano t-hamano force-pushed the quality/block-description-period branch from f739ed1 to a056a80 Compare December 16, 2023 03:21
ndiego
ndiego approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🚢

@t-hamano t-hamano merged commit cdeca67 into trunk Dec 17, 2023
51 checks passed
@t-hamano t-hamano deleted the quality/block-description-period branch December 17, 2023 01:38
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 17, 2023
artemiomorales pushed a commit that referenced this pull request Jan 4, 2024
@t-hamano @audrasjb @artemiomorales
Add missing period in block descriptions (#57131)
31939b5 
Co-authored-by: Jb Audras <audrasjb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndiego ndiego ndiego approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@t-hamano t-hamano

Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.4
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @ndiego