RSS Block: Update block styles #33294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Block] RSS
|
Size Change: +28 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kjellr
approved these changes
Jul 8, 2021
| @@ -1,4 +1,7 @@ | |||
| .wp-block-rss { | |||
| ul.wp-block-rss { // The ul is needed for specificity to override the reset styles in the editor. | |||
There was a problem hiding this comment.
We don't need this if #32659 lands (which I really hope it does)
There was a problem hiding this comment.
#32659 needs to land, I agree. In reviews an issue with the gallery block has been surfaced, that I want to poke at in more depth before I merge, and since I'm going on vacation today, I've held off on merging it even if I have two thumbs up to do so, as I want to be able to follow up.
I expect to do that followup when I get back from AFK. But if there's great urgency about landing it, just important to note there's a gallery aspect that needs followup.
scruffian
force-pushed
the
update/rss-block
branch
from
61ff6dc
to
6971fe9
Compare
scruffian
force-pushed
the
update/rss-block
branch
from
6971fe9
to
b9f7bd2
Compare
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* RSS Block: Update block styles * Add ul for the editor * Update comment
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the block styles for the RSS block:
How has this been tested?
In emptytheme
Screenshots
Before:
After:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).