Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS Block: Update block styles #33294

Merged
merged 3 commits into from
Jul 12, 2021
+4 −2
Merged

RSS Block: Update block styles #33294

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45ec5c1
RSS Block: Update block styles
scruffian Jul 8, 2021
54153de
Add ul for the editor
scruffian Jul 8, 2021
b9f7bd2
Update comment
scruffian Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/block-library/src/rss/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
.wp-block-rss {
ul.wp-block-rss { // The ul is needed for specificity to override the reset styles in the editor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this if #32659 lands (which I really hope it does)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#32659 needs to land, I agree. In reviews an issue with the gallery block has been surfaced, that I want to poke at in more depth before I merge, and since I'm going on vacation today, I've held off on merging it even if I have two thumbs up to do so, as I want to be able to follow up.

I expect to do that followup when I get back from AFK. But if there's great urgency about landing it, just important to note there's a gallery aspect that needs followup.

list-style: none;
padding: 0;

// This needs extra specificity due to the reset mixin on the parent: https://github.com/WordPress/gutenberg/blob/a250e9e5fe00dd5195624f96a3d924e7078951c3/packages/edit-post/src/style.scss#L54
&.wp-block-rss {
box-sizing: border-box;
Expand Down Expand Up @@ -36,6 +39,5 @@
.wp-block-rss__item-publish-date,
.wp-block-rss__item-author {
display: block;
color: #555;
font-size: 0.8125em;
}