-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint Plugin: Update eslint jsdoc dependency #34338
ESLint Plugin: Update eslint jsdoc dependency #34338
Conversation
Nice one. Thank you for taking care of the reported issue so quickly. Should we consider it a breaking change for the ESLint plugin package (it would also cascade to |
Thank you for the quick review! You're right, it should probably be considered as a breaking change (updated in the PR description). |
ffec4db
to
53bb848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included a commit that adds an entry to the CHANGELOG file for @wordpress/eslint-plugin
package and this PR should be good to go when CI turns green. Nice work, thank you for going through all the feedback shared 🙇🏻
It looks like this branch will need a rebase before we can proceed. |
It disables some rules that are failing after the eslint plugin update.
40cc88d
to
596512a
Compare
🎉 Let's merge when CI turns green 👍🏻 |
I see CI failures for the RN checks so we can ignore them here. |
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
Fixes #34297
Description
eslint-plugin-jsdoc
in order to solve the reported issue.How has this been tested?
npm run lint-js
in Gutenberg repo.Types of changes
Breaking change
Checklist:
*.native.js
files for terms that need renaming or removal).