[Mobile] - Global styles - Add support to render font sizes and line height #34144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +151 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
enejb
force-pushed
the
rnmobile/global-styles-font-size
branch
from
2328ab8
to
669a8b4
Compare
…ss/gutenberg into rnmobile/global-styles-font-size
geriux
changed the title
2 tasks
|
I tested this on iOS and I wasn't able to get the line-height settings to work. I cleared the cache and restarted Xcode to get it running as expected. :( Any ideas why its not working as expected in my testing? |
Interesting! Sorry that it didn't work by clearing the cache :( Could you try to run this on WordPress iOS and build again to see if it works? After you finish testing remember to change it back Let me know, thanks! |
|
Hey Gerardo 👋 Regarding the font size I noticed an issue (using the Quadra theme) with the text scrolling inside the paragraph after a certain text size. I only got to reproduce this once. I tried again with the same and other themes and it works as expected (resizing the block accordingly). I guess this may have to do with a glitch in Metro. Just noting this here in case it comes up again. Screenshot
|
|
Thanks for testing @antonis!
What was the issue exactly? Did you see the line-height setting there? Or was it missing? If it was missing, it is because the theme you have activated doesn't have support for it. (It might be related to the confusion with Quadra and Quadrat) If you saw the line-height selector setting and changing the value didn't work it might be related to the native changes not being included in the build. Let me know what you find once you test again with Quadrat.
It might be, I'll keep an eye if I encounter this. I tried to reproduce now but I couldn't. Thanks! |
enejb
approved these changes
Sep 8, 2021
Yay! Thank you for testing @enejb and for collaborating with these changes and adding Android support 👏 |
fullofcaffeine
added a commit
that referenced
this pull request
Sep 9, 2021
* trunk: (214 commits) Fix snackbar overflow on nav editor (#34661) Mobile - Allow disabling text and background color via theme.json (#34633) Fix disabled blocks logical error on Widgets screen (#34634) [Mobile] - Global styles - Add support to render font sizes and line height (#34144) ESLint Plugin: Update eslint jsdoc dependency (#34338) Scripts: Add CHANGELOG entry for `jest-dev-server` upgrade (#34657) Bump jest-dev-server to v5 (#34560) Refactor the `core-data` store to thunks (#28389) Only capture toolbars on parent Nav block when not in vertical mode (#34615) Update Changelog for 11.5.0-rc.1 Bump plugin version to 11.5.0-rc.1 Gallery block: Fix media placeholder height in site editor (#34629) Border Controls: Display color indicator and check selected color (#34467) Remove horizontal and vertical navigation block variations from inserter (#34614) AlignmentMatrixControl : Fix/update docs (#34624) Gap block support: force gap change to cause the block to re-render (fix Safari issue) (#34567) [Block Library - Social Links]: Use the new `flex` layout (#34493) [Mobile] Update the bottom sheet header (#34309) Group block: Add a row variation (#34535) Migrate entities.js to thunks (#34582) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#3924Description
This PR is a follow-up of #33605 and adds the functionality to render custom font sizes and line height in the editor.
This is under the
DEVflag.How has this been tested?
Notes to test in a dev build:
Test case 1 (font size)
Test case 2 (line-height)
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).