Lodash: Refactor components away from _.find()
#46537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
mirka,
aristath,
jsnajdr,
swissspidy,
ciampo,
geriux,
mkevins,
flootr,
chad1008,
fluiddot,
ntsekouras,
fabiankaegy and
brookewp
tyxla
commented
Dec 14, 2022
| @@ -290,8 +289,7 @@ function useAutocomplete( { | |||
| const textAfterSelection = getTextContent( | |||
| slice( record, undefined, getTextContent( record ).length ) | |||
| ); | |||
| const completer = find( | |||
| completers, | |||
| const completer = completers?.find( | |||
There was a problem hiding this comment.
Relies on the editor.Autocomplete.completers filter, so although we have completers enabled by default, it could end up being nullish. Adding optional chaining just in case.
| @@ -23,7 +18,7 @@ export default function BottomSheetPickerCell( props ) { | |||
| onChangeValue( newValue ); | |||
| }; | |||
|
|
|||
| const option = find( options, { value } ); | |||
| const option = options.find( ( opt ) => opt.value === value ); | |||
There was a problem hiding this comment.
options will default to an array:
| const mappedColor = find( defaultColors, { | ||
| slug: value, | ||
| } ); | ||
| const mappedColor = Object.values( defaultColors ?? {} ).find( |
There was a problem hiding this comment.
This comes in through an externally exposed API, so we're properly handling objects and nullish values.
| @@ -143,6 +143,7 @@ export function getBlockTypography( | |||
| const typographyStyles = {}; | |||
| const customBlockStyles = blockStyleAttributes?.style?.typography || {}; | |||
| const blockGlobalStyles = baseGlobalStyles?.blocks?.[ blockName ]; | |||
| const parsedFontSizes = Object.values( fontSizes ?? {} ); | |||
There was a problem hiding this comment.
This comes in through an externally exposed API, so we're properly handling objects and nullish values.
It's used twice below, which is why we've moved it here.
| const mappedFontSize = find( fontSizes, { | ||
| slug: fontSize, | ||
| } ); | ||
| const mappedFontSize = parsedFontSizes.find( |
There was a problem hiding this comment.
See above comment on L146.
| const mappedFontSize = find( fontSizes, { | ||
| slug: blockStyleAttributes?.fontSize, | ||
| } ); | ||
| const mappedFontSize = parsedFontSizes.find( |
There was a problem hiding this comment.
See above comment on L146.
| const matchedValue = find( mappedPresetValue.values, { | ||
| slug: path[ 1 ], | ||
| } ); | ||
| const matchedValue = Object.values( |
There was a problem hiding this comment.
Will be an object:
The ?? {} adds additional safety in the case of non-existence.
| const matchedValue = find( mappedValues.color?.values, { | ||
| slug: $2, | ||
| } ); | ||
| const matchedValue = mappedValues.color?.values?.find( |
| @@ -102,7 +101,7 @@ export function TabPanel( { | |||
| ) => { | |||
| child.click(); | |||
| }; | |||
| const selectedTab = find( tabs, { name: selected } ); | |||
| const selectedTab = tabs.find( ( { name } ) => name === selected ); | |||
There was a problem hiding this comment.
tabs is being used as an array universally in this component already.
|
Size Change: +19 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
dmsnell
pushed a commit
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.find()from thecomponentspackage. There are a few usages in that package and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
Array.prototype.find()instead of_.find(). Use optional chaining and conversion to array with a fallback when necessary.Testing Instructions
/in a new paragraph block).[[in a new paragraph block).