Update forked dependency to fix typescript error #34422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarani
added
the
Mobile App - i.e. Android or iOS
2 tasks
2 tasks
WunderBart
reviewed
Aug 31, 2021
gziolo
deleted the
rnmobile/fix/typescript-version-in-forked-dependency
branch
7 tasks
noisysocks
pushed a commit
that referenced
this pull request
Sep 1, 2021
* Update forked dependency to fix typescript error * Temporary: create new npm cache * Point to react-native-gesture-handler fork tag * Temporary: new npm cache for build-plugin-zip.sh * Revert "Temporary: new npm cache for build-plugin-zip.sh" This reverts commit b04adb2. * Revert "Temporary: create new npm cache" This reverts commit ab60daa.
|
I've 🍒 picked this PR into today's 11.4 release since the build was broken there too. Thank you! |
ramonjd
pushed a commit
that referenced
this pull request
Sep 1, 2021
* Update forked dependency to fix typescript error * Temporary: create new npm cache * Point to react-native-gesture-handler fork tag * Temporary: new npm cache for build-plugin-zip.sh * Revert "Temporary: new npm cache for build-plugin-zip.sh" This reverts commit b04adb2. * Revert "Temporary: create new npm cache" This reverts commit ab60daa.
ramonjd
pushed a commit
that referenced
this pull request
Sep 2, 2021
* Update forked dependency to fix typescript error * Temporary: create new npm cache * Point to react-native-gesture-handler fork tag * Temporary: new npm cache for build-plugin-zip.sh * Revert "Temporary: new npm cache for build-plugin-zip.sh" This reverts commit b04adb2. * Revert "Temporary: create new npm cache" This reverts commit ab60daa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34377
The TypeScript dependency was not pinned to a specific version which allowed it to fetch changes that brought in breaking changes to downstream clients of this library.
h/t to @ceyhun for figuring this one out.
Related:
How has this been tested?
Compressed SizeandPerformances Testsjobs, which will still fail because they testtrunk(which is currently broken). So if all other tests pass, the proposal here is to merge this PR despite these two failing tests. This will allowtrunkto work again.Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).