Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forked dependency to fix typescript error #3892

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Update forked dependency to fix typescript error #3892

merged 2 commits into from
Aug 31, 2021

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Aug 31, 2021

To test, see WordPress/gutenberg#34422

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani guarani added Tooling [Type] Bug Something isn't working bugfix labels Aug 31, 2021
@guarani guarani mentioned this pull request Aug 31, 2021
Merged
7 tasks
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani guarani enabled auto-merge August 31, 2021 17:59
@guarani guarani disabled auto-merge August 31, 2021 20:09
@guarani
Copy link
Contributor Author

guarani commented Aug 31, 2021

👋 @mchowning, could I ask you for a review here please? It's pointing to Gutenberg commit WordPress/gutenberg@29f73f0, which is a commit on trunk just after the merge commit of the linked Gutenberg PR.

@guarani guarani requested a review from mchowning August 31, 2021 20:10
mchowning
mchowning approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guarani guarani merged commit 3458ea3 into develop Aug 31, 2021
@guarani guarani deleted the fix/typescript-version-in-forked-dependency branch August 31, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees
No one assigned
Labels
bugfix Tooling [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guarani @mchowning