[RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers #34563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
fluiddot
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
LGTM 🎊 !
I also verified that previews look the same when previewing the post:
Resize mode ON:
| Vimeo | |
|---|---|
 |
 |
Resize mode OFF:
NOTE: Instagram is displayed the same as with the resize mode ON.
| Vimeo block | Vimeo preview |
|---|---|
 |
 |
I noticed that there's extra vertical padding on the block's content but it's also present when previewing the post on mobile.
I also tried this using the landscape layout and produces similar results:
Resize mode OFF:
| Block | Preview |
|---|---|
 |
 |
Resize mode ON:
| Block | Preview |
|---|---|
 |
 |
Tested on iPhone 11 (iOS 14.2) and Samsung Galaxy S20 FE 5G (Android 10).
|
I also tested these providers in the following site types: WP.com free site:
WP.com Atomic:
Self-hosted with Jetpack:
Self-hosted without Jetpack:
|
|
Thanks for assisting with verifying the behavior of the providers here @fluiddot 🙇🏾 |
jd-alexander
deleted the
rnmobile/embed-block-enable-preview-instagram-vimeo
branch
fullofcaffeine
added a commit
that referenced
this pull request
Sep 16, 2021
* trunk: (74 commits) Update docs for ClipboardButton component (#34711) Post Title Block: add typography formatting options (#31623) Bump plugin version to 11.5.0 Navigation Screen: Adjust header toolbar icon styles (#34833) Fix the parent menu item field in REST API responses (#34835) Rewrite FocusableIframe as hook API (#26753) Create Block: Remove wp-cli callout since not recommended and outdated (#34821) Global Styles: Fix dimensions panel default controls display (#34828) [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563) Increase Link UI search results to 10 on Nav Editor screen (#34808) Prevent welcome guide overflow x scroll (#34713) Enable open on click for Page List inside Navigation. (#34675) [RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update (#34674) Add missing field _invalid in menu item REST API (#34670) Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170) Navigation submenu block: replace global shortcut event handlers with local ones (#34812) Navigation Screen: Consolidate menu name and switcher (#34786) Remove parent and position validation from menu item REST API endpoint (#34672) Clean theme data when switching themes in the customizer (#34540) Components: add reset timeout to ColorPicker's copy functionality. (#34601) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3918Description
Adds Instagram and Vimeo to the static list of providers that the embed inline preview supports.
How has this been tested?
HTML code
Instagram
Vimeo
Other providers say "Embed previews not yet available"
Screenshots
iOS
Android
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).