Fix the parent menu item field in REST API responses #34835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
REST API Interaction
talldan
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
Mamaduka
reviewed
Sep 15, 2021
| @@ -671,7 +671,7 @@ public function prepare_item_for_response( $post, $request ) { | |||
|
|
|||
| if ( rest_is_field_included( 'parent', $fields ) ) { | |||
| // Same as post_parent, expose as integer. | |||
There was a problem hiding this comment.
Should we update this inline comment as well? To avoid the same mistake in the future.
Based on this property definition, menu_item_parent is what we need in this case.
There was a problem hiding this comment.
I think it's saying to treat the type of menu_item_parent as an int, the same as post_parent, so seems correct, but maybe a bit ambiguous.
Mamaduka
approved these changes
Sep 15, 2021
fullofcaffeine
added a commit
that referenced
this pull request
Sep 16, 2021
* trunk: (74 commits) Update docs for ClipboardButton component (#34711) Post Title Block: add typography formatting options (#31623) Bump plugin version to 11.5.0 Navigation Screen: Adjust header toolbar icon styles (#34833) Fix the parent menu item field in REST API responses (#34835) Rewrite FocusableIframe as hook API (#26753) Create Block: Remove wp-cli callout since not recommended and outdated (#34821) Global Styles: Fix dimensions panel default controls display (#34828) [RNMobile][Embed block] Enable embed preview for Instagram and Vimeo providers (#34563) Increase Link UI search results to 10 on Nav Editor screen (#34808) Prevent welcome guide overflow x scroll (#34713) Enable open on click for Page List inside Navigation. (#34675) [RNMobile] [Embed block] - Unavailable preview fallback bottom sheet title update (#34674) Add missing field _invalid in menu item REST API (#34670) Fix Dropdown/DropdownMenu toggle closing in all UAs (#31170) Navigation submenu block: replace global shortcut event handlers with local ones (#34812) Navigation Screen: Consolidate menu name and switcher (#34786) Remove parent and position validation from menu item REST API endpoint (#34672) Clean theme data when switching themes in the customizer (#34540) Components: add reset timeout to ColorPicker's copy functionality. (#34601) ...
This was referenced Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like there was a small regression in #34673 which caused menu items to return a
parentof0. Theparentfield was switched to using thepost_parentinstead of themenu_item_parentfield. Switching it back seems to fix things.I'm not sure exactly what the difference between the two is. It looks like there's a little difference in how
wp_setup_nav_menu_itemhandles this value - https://github.com/WordPress/wordpress-develop/blob/c3ef52ded7bb480899adfd2f69d9e3fddd210615/src/wp-includes/nav-menu.php#L819I'll add some tests for this once #34765 has been tackled.
How has this been tested?
Expected: the menu should have the same structure as when it was saved.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).