-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gallery block: Add a dismissible warning about the need for versions >=18.2 of the mobile app #36012
Conversation
Size Change: +1.06 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
3f514ca
to
d9b10b3
Compare
The banner shifts the content around in the canvas, but also might just be ignored. Does the notice disappear if I deselect the Gallery block? Will everyone see this notice when adding a Gallery block for the first time after updating? -- My first thought was to question the need for such an obtrusive message when anyone inserts the new Gallery block for the first time. I realize its probably hard (or impossible) to know who on web is also editing via mobile, but that would help reduce down the audience for this notice. Maybe it would be better to present the notice when saving/publishing? Or, maybe the notice can be less conspicuous; Something like a snackbar, or just visually smaller (less text, smaller font) than it is currently? If we think it does need to be intrusive and explicit, maybe this should use a dialog? |
@shaunandrews I agree that in normal circumstances we wouldn't go with this sort of approach. The issue we have is that there is the potential for data loss for mobile app users with version less that 18.2, ie. if they add a gallery on the web, and then edit the page on the app the images will all be lost, and in android it autosaves, so if the gallery is off screen when they edit they may not realise. We have no way of knowing which users may follow this flow, and no way to notify them from the mobile side. Because of the data loss issue I think it is important that it is very noticeable - and snackbars and top of screen notices are often missed by users ... but a blocking dialog is maybe too obtrusive. It may be that we only need to include this for a couple of releases of the plugin, by which time the number of users on outdated app versions may be low enough to drop it. ... but happy to look changing to a one time dialog if the consensus is that that is a better approach. |
I agree with Shaun that moving content around on the canvas is not ideal. What if we put this in the block header of the sidebar instead? Still non standard but more obvious, without being immediately intrusive and disruptive? I also don't think folks generally have a clue what version of an app they have installed. I have no idea and I bet I'm not the only one. What if instead we said "Please make sure you've updated to the latest version of the WordPress mobile app before editing this post on a mobile device."? |
Wouldn't this be missed if they don't have the sidebar open? I worry some folks would miss it entirely 🤔 |
That would be my concern - even if the sidebar was open I think it would be easily overlooked. |
One issue is, some users cannot always update to the latest version, such as when they are on a device which is below the Otoh, I think this would likely a small bucket of users, so curious what the negatives are to weigh against for that wording. Is the concern that conveying version information has the perception of being overly technical for many users? |
Probably worth linking to wordpress.org/mobile while mentioning apps on web? Could this look little less like an error visually, and more like a friendly nudge that you can quickly ignore? Something like this (screenshot from Google Docs): Another example from Figma: |
@simison, have added the link to the mobile site, and also switched from warning to info for the notice. Based on the examples you gave have also made the notice float over the gallery rather than take up canvas space: @apeatling, @shaunandrews what do you think of this approach? |
We should not have a message cover up the images, especially to show a warning that will likely not effect the user looking at it. If we are set on including an app warning on web view, let's add it to the save flow in the sidebar. |
The trouble with that approach is we would need to parse the post at save time to see if it contains any new gallery blocks which is a bit of unnecessary overhead. It is more meaningful and useful if the notice is added at the point when the user adds a new gallery in my view. I think it is critical that we get some sort of messaging in for this, so will explore using a snackbar instead if people are apposed to an in canvas message, as they can at least be added at the point of gallery insertion. |
5f76f34
to
2e8117c
Compare
I think my main concern would be that few people know the version, so it raises concern/FUD in everyone reading it, rather than the small minority that actually have an issue. I don't feel strongly enough here to be super concerned, so I'm fine continuing as is if I'm the only one. |
I have changed this to a one time snackbar instead of the in canvas notice if people can retest please. |
|
||
createWarningNotice( | ||
__( | ||
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.' | |
'Editing this Gallery Block in the WordPress mobile app requires version 18.2 or higher.' |
Very subjective. Feel free to ignore.
I think, at least, style required caps for blocks and WordPress for the product.
Also, would you think it's overboard to add a link to https://wp.com/app to upgrade? Might be too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this updated wording (and using WordPress instead of WP). In both cases, there's an additional word hanging over onto another line. If we remove the word "block", it looks like we can get the notice onto a single line (in English at least):
Before | After |
---|---|
But does that make it too brief if we remove the additional word?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as advertised for me. Happy to defer to the UX/designers here as well.
I have a small comment about adjusting the copy, I think "WordPress" and caps case for block names reflect current usage on wordpress.org. The rest is personal preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well for me, too @glendaviesnz! Just added that I think we might be able to remove the CSS rules, and I chimed in on Ramon's comment about the wording.
|
||
// Temporary notice to display warning about mobile app compat. Can be removed for 6.0 | ||
.components-notice { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this CSS rule be removed now? It doesn't look like it's targeting the snackbar notice.
|
||
createWarningNotice( | ||
__( | ||
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this updated wording (and using WordPress instead of WP). In both cases, there's an additional word hanging over onto another line. If we remove the word "block", it looks like we can get the notice onto a single line (in English at least):
Before | After |
---|---|
But does that make it too brief if we remove the additional word?
Snack bar feels nicer - much less obtrusive. |
44c3e3e
to
5a2af9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glendaviesnz, the text change looks good to me!
One thing I noticed is that if instead of adding a gallery block, I edit the gallery block by removing a gallery block, and then click Save, the notice appears at that stage in the process:
Personally, I think this is okay, as editing a post containing a gallery should probably also flag to a user the importance of running the latest version of the app, but I just thought I'd mention it in case it isn't intentional. Assuming it is, this LGTM!
Yeh, given it is a one off message I am happy with this. |
…obile app to edit the new gallery format
…nstead of inline warning
5a2af9e
to
f99b983
Compare
…>=18.2 of the mobile app (#36012) Co-authored-by: Glen Davies <glen.davies@a8c.com>
Cherry-picked into the GB 11.9 release in 6229877 |
Description
With the new Gallery block there is the potential for data loss if a user adds a Gallery block via web, and then edits in on the mobile app with a version < 18.2. There are currently around 12% of users on older versions and now way to prevent these users editing the new block format, or to notify them via the app about this.
This PR adds a dismissible snackbar notice when a new gallery block is added for the first time in the web. It is only a temporary notice and can be removed some time before the 6.0 release.
How has this been tested?
Screenshots