Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block: Add a dismissible warning about the need for versions >=18.2 of the mobile app #36012

Merged
merged 7 commits into from
Nov 7, 2021

Conversation

glendaviesnz
Copy link
Contributor

@glendaviesnz glendaviesnz commented Oct 27, 2021

Description

With the new Gallery block there is the potential for data loss if a user adds a Gallery block via web, and then edits in on the mobile app with a version < 18.2. There are currently around 12% of users on older versions and now way to prevent these users editing the new block format, or to notify them via the app about this.

This PR adds a dismissible snackbar notice when a new gallery block is added for the first time in the web. It is only a temporary notice and can be removed some time before the 6.0 release.

How has this been tested?

  • Check out this PR and enable the gallery experiment
  • Add a gallery block
  • Check that the mobile warning snackbar displays
  • Dismiss the notice and make sure that it doesn't display again when adding a new gallery, even after a browser restart
  • Clear local storage for test site to retest

Screenshots

snackbar

@glendaviesnz glendaviesnz added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Oct 27, 2021
@glendaviesnz glendaviesnz self-assigned this Oct 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Size Change: +1.06 kB (0%)

Total Size: 1.08 MB

Filename Size Change
build/block-library/index.min.js 160 kB +1.05 kB (+1%)
build/edit-post/index.min.js 29.4 kB +14 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 931 B
build/admin-manifest/index.min.js 1.09 kB
build/annotations/index.min.js 2.7 kB
build/api-fetch/index.min.js 2.17 kB
build/autop/index.min.js 2.08 kB
build/blob/index.min.js 459 B
build/block-directory/index.min.js 6.2 kB
build/block-directory/style-rtl.css 1.01 kB
build/block-directory/style.css 1.01 kB
build/block-editor/default-editor-styles-rtl.css 378 B
build/block-editor/default-editor-styles.css 378 B
build/block-editor/index.min.js 136 kB
build/block-editor/style-rtl.css 14.1 kB
build/block-editor/style.css 14.1 kB
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 65 B
build/block-library/blocks/archives/style.css 65 B
build/block-library/blocks/audio/editor-rtl.css 58 B
build/block-library/blocks/audio/editor.css 58 B
build/block-library/blocks/audio/style-rtl.css 111 B
build/block-library/blocks/audio/style.css 111 B
build/block-library/blocks/audio/theme-rtl.css 125 B
build/block-library/blocks/audio/theme.css 125 B
build/block-library/blocks/block/editor-rtl.css 161 B
build/block-library/blocks/block/editor.css 161 B
build/block-library/blocks/button/editor-rtl.css 470 B
build/block-library/blocks/button/editor.css 470 B
build/block-library/blocks/button/style-rtl.css 560 B
build/block-library/blocks/button/style.css 560 B
build/block-library/blocks/buttons/editor-rtl.css 292 B
build/block-library/blocks/buttons/editor.css 292 B
build/block-library/blocks/buttons/style-rtl.css 275 B
build/block-library/blocks/buttons/style.css 275 B
build/block-library/blocks/calendar/style-rtl.css 207 B
build/block-library/blocks/calendar/style.css 207 B
build/block-library/blocks/categories/editor-rtl.css 84 B
build/block-library/blocks/categories/editor.css 83 B
build/block-library/blocks/categories/style-rtl.css 79 B
build/block-library/blocks/categories/style.css 79 B
build/block-library/blocks/code/style-rtl.css 90 B
build/block-library/blocks/code/style.css 90 B
build/block-library/blocks/code/theme-rtl.css 131 B
build/block-library/blocks/code/theme.css 131 B
build/block-library/blocks/columns/editor-rtl.css 206 B
build/block-library/blocks/columns/editor.css 205 B
build/block-library/blocks/columns/style-rtl.css 503 B
build/block-library/blocks/columns/style.css 502 B
build/block-library/blocks/cover/editor-rtl.css 546 B
build/block-library/blocks/cover/editor.css 547 B
build/block-library/blocks/cover/style-rtl.css 1.17 kB
build/block-library/blocks/cover/style.css 1.17 kB
build/block-library/blocks/embed/editor-rtl.css 488 B
build/block-library/blocks/embed/editor.css 488 B
build/block-library/blocks/embed/style-rtl.css 417 B
build/block-library/blocks/embed/style.css 417 B
build/block-library/blocks/embed/theme-rtl.css 124 B
build/block-library/blocks/embed/theme.css 124 B
build/block-library/blocks/file/editor-rtl.css 300 B
build/block-library/blocks/file/editor.css 300 B
build/block-library/blocks/file/style-rtl.css 255 B
build/block-library/blocks/file/style.css 255 B
build/block-library/blocks/file/view.min.js 322 B
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB
build/block-library/blocks/freeform/editor.css 2.44 kB
build/block-library/blocks/gallery/editor-rtl.css 977 B
build/block-library/blocks/gallery/editor.css 982 B
build/block-library/blocks/gallery/style-rtl.css 1.6 kB
build/block-library/blocks/gallery/style.css 1.59 kB
build/block-library/blocks/gallery/theme-rtl.css 122 B
build/block-library/blocks/gallery/theme.css 122 B
build/block-library/blocks/group/editor-rtl.css 159 B
build/block-library/blocks/group/editor.css 159 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 114 B
build/block-library/blocks/heading/style.css 114 B
build/block-library/blocks/home-link/style-rtl.css 247 B
build/block-library/blocks/home-link/style.css 247 B
build/block-library/blocks/html/editor-rtl.css 332 B
build/block-library/blocks/html/editor.css 333 B
build/block-library/blocks/image/editor-rtl.css 731 B
build/block-library/blocks/image/editor.css 730 B
build/block-library/blocks/image/style-rtl.css 502 B
build/block-library/blocks/image/style.css 505 B
build/block-library/blocks/image/theme-rtl.css 124 B
build/block-library/blocks/image/theme.css 124 B
build/block-library/blocks/latest-comments/style-rtl.css 284 B
build/block-library/blocks/latest-comments/style.css 284 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B
build/block-library/blocks/latest-posts/editor.css 137 B
build/block-library/blocks/latest-posts/style-rtl.css 528 B
build/block-library/blocks/latest-posts/style.css 527 B
build/block-library/blocks/list/style-rtl.css 94 B
build/block-library/blocks/list/style.css 94 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 493 B
build/block-library/blocks/media-text/style.css 490 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 642 B
build/block-library/blocks/navigation-link/editor.css 642 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B
build/block-library/blocks/navigation-link/style.css 94 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 299 B
build/block-library/blocks/navigation-submenu/editor.css 299 B
build/block-library/blocks/navigation-submenu/style-rtl.css 195 B
build/block-library/blocks/navigation-submenu/style.css 195 B
build/block-library/blocks/navigation-submenu/view.min.js 343 B
build/block-library/blocks/navigation/editor-rtl.css 1.93 kB
build/block-library/blocks/navigation/editor.css 1.93 kB
build/block-library/blocks/navigation/style-rtl.css 1.72 kB
build/block-library/blocks/navigation/style.css 1.7 kB
build/block-library/blocks/navigation/view.min.js 2.74 kB
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 377 B
build/block-library/blocks/page-list/editor.css 377 B
build/block-library/blocks/page-list/style-rtl.css 198 B
build/block-library/blocks/page-list/style.css 198 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B
build/block-library/blocks/paragraph/editor.css 157 B
build/block-library/blocks/paragraph/style-rtl.css 273 B
build/block-library/blocks/paragraph/style.css 273 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/style-rtl.css 347 B
build/block-library/blocks/post-comments-form/style.css 347 B
build/block-library/blocks/post-comments/style-rtl.css 492 B
build/block-library/blocks/post-comments/style.css 493 B
build/block-library/blocks/post-content/style-rtl.css 56 B
build/block-library/blocks/post-content/style.css 56 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B
build/block-library/blocks/post-excerpt/editor.css 73 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B
build/block-library/blocks/post-excerpt/style.css 69 B
build/block-library/blocks/post-featured-image/editor-rtl.css 396 B
build/block-library/blocks/post-featured-image/editor.css 397 B
build/block-library/blocks/post-featured-image/style-rtl.css 156 B
build/block-library/blocks/post-featured-image/style.css 156 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 391 B
build/block-library/blocks/post-template/style.css 392 B
build/block-library/blocks/post-terms/style-rtl.css 73 B
build/block-library/blocks/post-terms/style.css 73 B
build/block-library/blocks/post-title/style-rtl.css 60 B
build/block-library/blocks/post-title/style.css 60 B
build/block-library/blocks/preformatted/style-rtl.css 103 B
build/block-library/blocks/preformatted/style.css 103 B
build/block-library/blocks/pullquote/editor-rtl.css 198 B
build/block-library/blocks/pullquote/editor.css 198 B
build/block-library/blocks/pullquote/style-rtl.css 378 B
build/block-library/blocks/pullquote/style.css 378 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 262 B
build/block-library/blocks/query-pagination/editor.css 255 B
build/block-library/blocks/query-pagination/style-rtl.css 234 B
build/block-library/blocks/query-pagination/style.css 231 B
build/block-library/blocks/query/editor-rtl.css 131 B
build/block-library/blocks/query/editor.css 132 B
build/block-library/blocks/quote/style-rtl.css 187 B
build/block-library/blocks/quote/style.css 187 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/rss/editor-rtl.css 202 B
build/block-library/blocks/rss/editor.css 204 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 165 B
build/block-library/blocks/search/editor.css 165 B
build/block-library/blocks/search/style-rtl.css 397 B
build/block-library/blocks/search/style.css 398 B
build/block-library/blocks/search/theme-rtl.css 64 B
build/block-library/blocks/search/theme.css 64 B
build/block-library/blocks/separator/editor-rtl.css 99 B
build/block-library/blocks/separator/editor.css 99 B
build/block-library/blocks/separator/style-rtl.css 245 B
build/block-library/blocks/separator/style.css 245 B
build/block-library/blocks/separator/theme-rtl.css 172 B
build/block-library/blocks/separator/theme.css 172 B
build/block-library/blocks/shortcode/editor-rtl.css 474 B
build/block-library/blocks/shortcode/editor.css 474 B
build/block-library/blocks/site-logo/editor-rtl.css 770 B
build/block-library/blocks/site-logo/editor.css 770 B
build/block-library/blocks/site-logo/style-rtl.css 165 B
build/block-library/blocks/site-logo/style.css 165 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 84 B
build/block-library/blocks/site-title/editor.css 84 B
build/block-library/blocks/social-link/editor-rtl.css 177 B
build/block-library/blocks/social-link/editor.css 177 B
build/block-library/blocks/social-links/editor-rtl.css 824 B
build/block-library/blocks/social-links/editor.css 823 B
build/block-library/blocks/social-links/style-rtl.css 1.32 kB
build/block-library/blocks/social-links/style.css 1.32 kB
build/block-library/blocks/spacer/editor-rtl.css 307 B
build/block-library/blocks/spacer/editor.css 307 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 471 B
build/block-library/blocks/table/editor.css 472 B
build/block-library/blocks/table/style-rtl.css 481 B
build/block-library/blocks/table/style.css 481 B
build/block-library/blocks/table/theme-rtl.css 188 B
build/block-library/blocks/table/theme.css 188 B
build/block-library/blocks/tag-cloud/style-rtl.css 146 B
build/block-library/blocks/tag-cloud/style.css 146 B
build/block-library/blocks/template-part/editor-rtl.css 560 B
build/block-library/blocks/template-part/editor.css 559 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 87 B
build/block-library/blocks/verse/style.css 87 B
build/block-library/blocks/video/editor-rtl.css 571 B
build/block-library/blocks/video/editor.css 572 B
build/block-library/blocks/video/style-rtl.css 173 B
build/block-library/blocks/video/style.css 173 B
build/block-library/blocks/video/theme-rtl.css 124 B
build/block-library/blocks/video/theme.css 124 B
build/block-library/common-rtl.css 815 B
build/block-library/common.css 812 B
build/block-library/editor-rtl.css 9.88 kB
build/block-library/editor.css 9.88 kB
build/block-library/reset-rtl.css 474 B
build/block-library/reset.css 474 B
build/block-library/style-rtl.css 10.5 kB
build/block-library/style.css 10.5 kB
build/block-library/theme-rtl.css 668 B
build/block-library/theme.css 673 B
build/block-serialization-default-parser/index.min.js 1.09 kB
build/block-serialization-spec-parser/index.min.js 2.79 kB
build/blocks/index.min.js 46 kB
build/components/index.min.js 213 kB
build/components/style-rtl.css 15.3 kB
build/components/style.css 15.3 kB
build/compose/index.min.js 10.9 kB
build/core-data/index.min.js 12.8 kB
build/customize-widgets/index.min.js 11.2 kB
build/customize-widgets/style-rtl.css 1.5 kB
build/customize-widgets/style.css 1.49 kB
build/data-controls/index.min.js 614 B
build/data/index.min.js 7.15 kB
build/date/index.min.js 31.5 kB
build/deprecated/index.min.js 428 B
build/dom-ready/index.min.js 304 B
build/dom/index.min.js 4.44 kB
build/edit-navigation/index.min.js 15.9 kB
build/edit-navigation/style-rtl.css 3.73 kB
build/edit-navigation/style.css 3.73 kB
build/edit-post/classic-rtl.css 492 B
build/edit-post/classic.css 494 B
build/edit-post/style-rtl.css 7.1 kB
build/edit-post/style.css 7.1 kB
build/edit-site/index.min.js 28 kB
build/edit-site/style-rtl.css 5.3 kB
build/edit-site/style.css 5.3 kB
build/edit-widgets/index.min.js 16.4 kB
build/edit-widgets/style-rtl.css 4.15 kB
build/edit-widgets/style.css 4.16 kB
build/editor/index.min.js 37.5 kB
build/editor/style-rtl.css 3.78 kB
build/editor/style.css 3.77 kB
build/element/index.min.js 3.21 kB
build/escape-html/index.min.js 517 B
build/format-library/index.min.js 6.38 kB
build/format-library/style-rtl.css 571 B
build/format-library/style.css 571 B
build/hooks/index.min.js 1.55 kB
build/html-entities/index.min.js 424 B
build/i18n/index.min.js 3.6 kB
build/is-shallow-equal/index.min.js 501 B
build/keyboard-shortcuts/index.min.js 1.72 kB
build/keycodes/index.min.js 1.3 kB
build/list-reusable-blocks/index.min.js 1.85 kB
build/list-reusable-blocks/style-rtl.css 838 B
build/list-reusable-blocks/style.css 838 B
build/media-utils/index.min.js 2.91 kB
build/notices/index.min.js 845 B
build/nux/index.min.js 2.03 kB
build/nux/style-rtl.css 747 B
build/nux/style.css 743 B
build/plugins/index.min.js 1.83 kB
build/primitives/index.min.js 921 B
build/priority-queue/index.min.js 582 B
build/react-i18n/index.min.js 671 B
build/redux-routine/index.min.js 2.63 kB
build/reusable-blocks/index.min.js 2.19 kB
build/reusable-blocks/style-rtl.css 256 B
build/reusable-blocks/style.css 256 B
build/rich-text/index.min.js 10.8 kB
build/server-side-render/index.min.js 1.52 kB
build/shortcode/index.min.js 1.48 kB
build/token-list/index.min.js 562 B
build/url/index.min.js 1.82 kB
build/viewport/index.min.js 1.02 kB
build/warning/index.min.js 248 B
build/widgets/index.min.js 7.11 kB
build/widgets/style-rtl.css 1.16 kB
build/widgets/style.css 1.16 kB
build/wordcount/index.min.js 1.04 kB

compressed-size-action

@glendaviesnz glendaviesnz force-pushed the add/gallery-mobile-app-warning branch from 3f514ca to d9b10b3 Compare October 27, 2021 22:00
@shaunandrews
Copy link
Contributor

The banner shifts the content around in the canvas, but also might just be ignored. Does the notice disappear if I deselect the Gallery block? Will everyone see this notice when adding a Gallery block for the first time after updating?

--

My first thought was to question the need for such an obtrusive message when anyone inserts the new Gallery block for the first time. I realize its probably hard (or impossible) to know who on web is also editing via mobile, but that would help reduce down the audience for this notice.

Maybe it would be better to present the notice when saving/publishing? Or, maybe the notice can be less conspicuous; Something like a snackbar, or just visually smaller (less text, smaller font) than it is currently?

If we think it does need to be intrusive and explicit, maybe this should use a dialog?

@glendaviesnz
Copy link
Contributor Author

@shaunandrews I agree that in normal circumstances we wouldn't go with this sort of approach. The issue we have is that there is the potential for data loss for mobile app users with version less that 18.2, ie. if they add a gallery on the web, and then edit the page on the app the images will all be lost, and in android it autosaves, so if the gallery is off screen when they edit they may not realise. We have no way of knowing which users may follow this flow, and no way to notify them from the mobile side.

Because of the data loss issue I think it is important that it is very noticeable - and snackbars and top of screen notices are often missed by users ... but a blocking dialog is maybe too obtrusive.

It may be that we only need to include this for a couple of releases of the plugin, by which time the number of users on outdated app versions may be low enough to drop it.

... but happy to look changing to a one time dialog if the consensus is that that is a better approach.

@apeatling
Copy link
Contributor

apeatling commented Oct 28, 2021

I agree with Shaun that moving content around on the canvas is not ideal. What if we put this in the block header of the sidebar instead? Still non standard but more obvious, without being immediately intrusive and disruptive?

I also don't think folks generally have a clue what version of an app they have installed. I have no idea and I bet I'm not the only one. What if instead we said "Please make sure you've updated to the latest version of the WordPress mobile app before editing this post on a mobile device."?

@stacimc
Copy link
Contributor

stacimc commented Oct 28, 2021

What if we put this in the block header of the sidebar instead? Still non standard but more obvious

Wouldn't this be missed if they don't have the sidebar open? I worry some folks would miss it entirely 🤔

@glendaviesnz
Copy link
Contributor Author

Wouldn't this be missed if they don't have the sidebar open?

That would be my concern - even if the sidebar was open I think it would be easily overlooked.

@mkevins
Copy link
Contributor

mkevins commented Oct 29, 2021

@apeatling 👋

I also don't think folks generally have a clue what version of an app they have installed. I have no idea and I bet I'm not the only one. What if instead we said "Please make sure you've updated to the latest version of the WordPress mobile app before editing this post on a mobile device."?

One issue is, some users cannot always update to the latest version, such as when they are on a device which is below the minSdk of the latest version of the app. minSdk bumps are typically infrequent, and, while we recently bumped this prior to the 18.2 boundary, there may be value in communicating version information for affected users if we have another minSdk bump, so that users on a version prior to 18.2 can upgrade to a version >= 18.2, even if not the latest version.

Otoh, I think this would likely a small bucket of users, so curious what the negatives are to weigh against for that wording. Is the concern that conveying version information has the perception of being overly technical for many users?

@simison
Copy link
Member

simison commented Oct 29, 2021

Probably worth linking to wordpress.org/mobile while mentioning apps on web?

Could this look little less like an error visually, and more like a friendly nudge that you can quickly ignore?

Something like this (screenshot from Google Docs):

Screenshot 2021-10-29 at 12 04 35

Another example from Figma:

Screenshot 2021-10-30 at 16 35 26

@glendaviesnz
Copy link
Contributor Author

@simison, have added the link to the mobile site, and also switched from warning to info for the notice. Based on the examples you gave have also made the notice float over the gallery rather than take up canvas space:

Screen Shot 2021-11-01 at 11 59 37 AM

@apeatling, @shaunandrews what do you think of this approach?

@kellychoffman
Copy link
Contributor

We should not have a message cover up the images, especially to show a warning that will likely not effect the user looking at it.

If we are set on including an app warning on web view, let's add it to the save flow in the sidebar.

@glendaviesnz
Copy link
Contributor Author

glendaviesnz commented Nov 4, 2021

If we are set on including an app warning on web view, let's add it to the save flow in the sidebar.

The trouble with that approach is we would need to parse the post at save time to see if it contains any new gallery blocks which is a bit of unnecessary overhead. It is more meaningful and useful if the notice is added at the point when the user adds a new gallery in my view. I think it is critical that we get some sort of messaging in for this, so will explore using a snackbar instead if people are apposed to an in canvas message, as they can at least be added at the point of gallery insertion.

@glendaviesnz glendaviesnz force-pushed the add/gallery-mobile-app-warning branch from 5f76f34 to 2e8117c Compare November 4, 2021 21:26
@apeatling
Copy link
Contributor

apeatling commented Nov 4, 2021

Otoh, I think this would likely a small bucket of users, so curious what the negatives are to weigh against for that wording. Is the concern that conveying version information has the perception of being overly technical for many users?

I think my main concern would be that few people know the version, so it raises concern/FUD in everyone reading it, rather than the small minority that actually have an issue.

I don't feel strongly enough here to be super concerned, so I'm fine continuing as is if I'm the only one.

@glendaviesnz
Copy link
Contributor Author

I have changed this to a one time snackbar instead of the in canvas notice if people can retest please.


createWarningNotice(
__(
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.'
'Editing this Gallery Block in the WordPress mobile app requires version 18.2 or higher.'

Very subjective. Feel free to ignore.

I think, at least, style required caps for blocks and WordPress for the product.

Also, would you think it's overboard to add a link to https://wp.com/app to upgrade? Might be too much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this updated wording (and using WordPress instead of WP). In both cases, there's an additional word hanging over onto another line. If we remove the word "block", it looks like we can get the notice onto a single line (in English at least):

Before After
image image

But does that make it too brief if we remove the additional word?

@ramonjd
Copy link
Member

ramonjd commented Nov 4, 2021

Here's what I'm seeing:

✅ The warning appears when I add a new gallery
✅ If I dismiss, or refresh the page, subsequent gallery additions do not trigger the warning

Screen Shot 2021-11-05 at 10 03 41 am

Narrow width:
Screen Shot 2021-11-05 at 10 18 08 am

Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised for me. Happy to defer to the UX/designers here as well.

I have a small comment about adjusting the copy, I think "WordPress" and caps case for block names reflect current usage on wordpress.org. The rest is personal preference.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me, too @glendaviesnz! Just added that I think we might be able to remove the CSS rules, and I chimed in on Ramon's comment about the wording.


// Temporary notice to display warning about mobile app compat. Can be removed for 6.0
.components-notice {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this CSS rule be removed now? It doesn't look like it's targeting the snackbar notice.


createWarningNotice(
__(
'To edit this Gallery block in the WP mobile app you need to be using version 18.2 or higher.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this updated wording (and using WordPress instead of WP). In both cases, there's an additional word hanging over onto another line. If we remove the word "block", it looks like we can get the notice onto a single line (in English at least):

Before After
image image

But does that make it too brief if we remove the additional word?

@andrewserong andrewserong added the [Type] Enhancement A suggestion for improvement. label Nov 5, 2021
@kellychoffman
Copy link
Contributor

Snack bar feels nicer - much less obtrusive. :shipit:

@glendaviesnz glendaviesnz force-pushed the add/gallery-mobile-app-warning branch from 44c3e3e to 5a2af9e Compare November 5, 2021 02:51
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glendaviesnz, the text change looks good to me!

One thing I noticed is that if instead of adding a gallery block, I edit the gallery block by removing a gallery block, and then click Save, the notice appears at that stage in the process:

Kapture 2021-11-05 at 14 01 52

Personally, I think this is okay, as editing a post containing a gallery should probably also flag to a user the importance of running the latest version of the app, but I just thought I'd mention it in case it isn't intentional. Assuming it is, this LGTM!

@glendaviesnz
Copy link
Contributor Author

Personally, I think this is okay, as editing a post containing a gallery should probably also flag to a user the importance of running the latest version of the app

Yeh, given it is a one off message I am happy with this.

@ramonjd ramonjd force-pushed the add/gallery-mobile-app-warning branch from 5a2af9e to f99b983 Compare November 5, 2021 10:44
@glendaviesnz glendaviesnz merged commit 0d10833 into trunk Nov 7, 2021
@glendaviesnz glendaviesnz deleted the add/gallery-mobile-app-warning branch November 7, 2021 19:52
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 7, 2021
@andrewserong andrewserong mentioned this pull request Nov 7, 2021
28 tasks
andrewserong pushed a commit that referenced this pull request Nov 7, 2021
…>=18.2 of the mobile app (#36012)

Co-authored-by: Glen Davies <glen.davies@a8c.com>
@andrewserong
Copy link
Contributor

Cherry-picked into the GB 11.9 release in 6229877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants