-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minSdk to 24 #15135
Update minSdk to 24 #15135
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APKs: |
92d5780
to
12ddc20
Compare
3fe586d
to
32bc09a
Compare
32bc09a
to
90ccc1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, for the little understanding of Android that I have.
Looking at the diff without whitespace changes confirms that the code that was inside if statements hasn't been modified 👍
I run the app on the Emulator and posted a story because I saw that a few stories fragments did change. 🤷♂️
Fixes #15077 in combination with #15085 & #15138.
After an internal discussion, we decided to upgrade
minSdk
to 24 as we have less than 5% of our users on the earlier versions of Android.I've also taken the opportunity to remove the
versionName
andversionCode
values there were outdated.Besides upgrading the
minSdk
, it removes obsolete checks for the earlier versions of sdk. I suggest turning on thehide whitespaces
option to review these changes.The only change that should be given extra attention to is 90ccc1a which merges
values-v23
intovalues
since these values will always be available. This is also what the lint task recommended to do.Note that Automattic/stories-android#711 needs to be merged and thelibs/stories-android
submodule needs to be updated before this can be merged.To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.