Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minSdk to 24 #15135

Merged
merged 9 commits into from
Aug 5, 2021
Merged

Update minSdk to 24 #15135

merged 9 commits into from
Aug 5, 2021

Conversation

oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Aug 4, 2021

Fixes #15077 in combination with #15085 & #15138.

After an internal discussion, we decided to upgrade minSdk to 24 as we have less than 5% of our users on the earlier versions of Android.

I've also taken the opportunity to remove the versionName and versionCode values there were outdated.
Besides upgrading the minSdk, it removes obsolete checks for the earlier versions of sdk. I suggest turning on the hide whitespaces option to review these changes.

The only change that should be given extra attention to is 90ccc1a which merges values-v23 into values since these values will always be available. This is also what the lint task recommended to do.

Note that Automattic/stories-android#711 needs to be merged and the libs/stories-android submodule needs to be updated before this can be merged.

To test:

  • Verify the app still works 🤷

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@oguzkocer oguzkocer added this to the 18.0 milestone Aug 4, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021

You can test the changes on this Pull Request by downloading the APKs:

@oguzkocer oguzkocer force-pushed the update-min-sdk-to-24 branch from 92d5780 to 12ddc20 Compare August 4, 2021 16:18
@oguzkocer oguzkocer force-pushed the update-min-sdk-to-24 branch 3 times, most recently from 3fe586d to 32bc09a Compare August 5, 2021 03:06
@oguzkocer oguzkocer force-pushed the update-min-sdk-to-24 branch from 32bc09a to 90ccc1a Compare August 5, 2021 03:27
@oguzkocer oguzkocer marked this pull request as ready for review August 5, 2021 04:00
@oguzkocer oguzkocer requested a review from a team August 5, 2021 04:00
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, for the little understanding of Android that I have.

Looking at the diff without whitespace changes confirms that the code that was inside if statements hasn't been modified 👍

I run the app on the Emulator and posted a story because I saw that a few stories fragments did change. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New lint errors in Gradle 7.1.1 & Android Gradle Plugin 4.2.2
3 participants