Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content description to FAB #15085

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jul 27, 2021

Parent #15077

This PR fixes lint error by adding content description to:
media_picker_fragment.xml
photo_picker_fragment.xml

For more details see: paqN3M-mc

To test:

  • Open your device's Settings app.
  • Navigate to Accessibility and select TalkBack.
  • At the top of the TalkBack screen, press On/Off to turn on TalkBack.
  • In the confirmation dialog, select OK to confirm permissions.
  • Navigate to stories and tap the FAB
  • Listen for the content description 'Open Camera'
  • Navigate to media picker and tap the FAB
  • Listen for the content description 'Open Camera'

Regression Notes

  1. Potential unintended areas of impact 🟢
  2. What I did to test those areas of impact (or what existing automated tests I relied on) 🟢
  3. What automated tests I added (or what prevented me from doing so) 🟢

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@zwarm zwarm added this to the 18.0 milestone Jul 27, 2021
@zwarm zwarm requested review from oguzkocer and ParaskP7 July 27, 2021 13:57
@zwarm zwarm self-assigned this Jul 27, 2021
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@ParaskP7 ParaskP7 self-assigned this Jul 27, 2021
Copy link
Contributor

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @zwarm !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟

@zwarm zwarm merged commit 2c2e6a3 into develop Jul 27, 2021
@zwarm zwarm deleted the issue/15077-fix-missing-content-desc branch July 27, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants