Fix: apply by slug on all origins #36841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
|
Size Change: +216 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
fix/apply-by-slug-on-all-origins
branch
from
7eac58d to
c00b485
Compare
|
Rebased to fix some PHP tests that were removed from this repo and ported to WordPress core. Also pushed a fix for the inline styles that are serialized to the block to cover themes that don't enqueue styles for the editor. Without c00b485 How to test: upon selecting a preset background color for the paragraph block, in addition to the classes the block should have the inline styles as well. |
|
Pushed acf458c to fix the utils some blocks use (button, table, search) to serialize classes & inline styles. The inline styles we generate to cover for blocks not enqueuing their own styles were missing. |
|
Testing this and looking for more code changes run into another place we need to update #36886 |
jorgefilipecosta
force-pushed
the
fix/apply-by-slug-on-all-origins
branch
from
96d0161 to
21c3331
Compare
jorgefilipecosta
force-pushed
the
fix/apply-by-slug-on-all-origins
branch
from
21c3331 to
f6588c6
Compare
|
The test failures are also happening on master and don't seem related to this PR. So I'm merging it. #36886 should be addressed in a different PR. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
Co-authored-by: André <583546+oandregal@users.noreply.github.com>
7 tasks
oandregal
reviewed
Dec 3, 2021
| @@ -67,7 +65,15 @@ export function __experimentalUseGradient( { | |||
| } = {} ) { | |||
| const { clientId } = useBlockEditContext(); | |||
|
|
|||
| const gradients = useSetting( 'color.gradients' ) || EMPTY_ARRAY; | |||
| const { gradients: gradientsPerOrigin } = useSetting( 'color' ) || {}; | |||
There was a problem hiding this comment.
|
@jorgefilipecosta I've reopened #36770 as I still can reproduce it. |
This was referenced Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #36770
Currently, at the block level, when we select a color/gradient from the default palette or the theme palette, if there is a custom palette, the color is applied as an inline style instead of being applied as a class or variable as it should.
These PR makes sure independently of the color palette chosen, the editor always colors and gradients with a class or CSS variable.
How has this been tested?
I went to the paragraph block and applied a background, text, and link color from the default palette. I verified background and text colors are applied using classes, and link color references a CSS variable.
I went to the group block and applied a gradient background from the default palette. I verified the background was applied using a class.
I went to the color block (a block with a specific color implementation) and applied a background color from the default palette. I verified the color was applied using a class.
I went to the color block and applied a background gradient from the default palette. I verified the gradient was applied using a class.