Fix usage of useSetting('color.palette') #37108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Automated Testing
youknowriad
force-pushed
the
fix/use-setting-call-color-palette
branch
2 times, most recently
from
a3608e7
to
d008d0b
Compare
|
Size Change: +26 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Dec 3, 2021
7 tasks
|
Thanks for fixing this one 🙇 I've got a PR going that addresses the (latest) PHP unit test fails. If it's not merged by an admin before, would you mind sending it on its way with this PR? (I can't merge due to CI errors). Thank you! |
noisysocks
force-pushed
the
fix/use-setting-call-color-palette
branch
from
d008d0b
to
8c52346
Compare
|
Thanks for following up with this fix! I've pushed another commit 5af4d2e (hope you don't mind @youknowriad!) that adds back in fallback empty arrays when using the spread syntax as the mobile unit tests had some failures that appear to be related to that change. |
7 tasks
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Fix usage of useSetting('color.palette')
* Add fallback empty array to prevent spread syntax error with undefined values
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two recent PRs changing how we consume color palette settings conflicted and resulted in broken unit test (and broken behavior as well)
useSetting( 'color.palette' )to useSetting( 'color') in order to consume all subways (theme, default, custom): this is not great since useSetting( 'color' ) doesn't handle backward compatibility properly and shouldn't be used (ideally should be deprecated in favor of leaf keys. Fix: apply by slug on all origins #36841useSetting('color.palette')is different thanuseSetting('color').paletteresulting in some breakage. Gradient: Fix clearing a custom gradient from throwing a React warning #37051The unstable php tests (from core) didn't help identify that the test failures were actually valid.
This one tries to reconcile both.