PHP Unit Tests: Use global transients

[ramonjd]

Description

This PR is a just a test to see whether changing to the pre_site_transient_filter fixes the PHP unit tests, reflecting the changes in https://core.trac.wordpress.org/changeset/52311

How has this been tested?

Silently. Waiting in the dark until the PHP Unit tests pass.

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

[ramonjd]

From here:

Does that mean we'd have to update https://github.com/WordPress/gutenberg/blob/36746203fb97e715d709adbc9e9ff71037a42f14/lib/class-wp-rest-url-details-controller.php with the same changes as https://core.trac.wordpress.org/changeset/52311?

I have no context about why Gutenberg has it's own WP_REST_URL_Details_Controller class.

[Mamaduka]

Good catch, @ramonjd 👍

I have no context about why Gutenberg has it's own WP_REST_URL_Details_Controller class.

The plugin has to support older versions of WP, and this is the new API available in 5.9. The WP_REST_URL_Details_Controller class is conditionally loaded. This and unit tests being out of sync is also the reason for test failures.

Maybe we should start removing unit tests for APIs that are part of WP core since updates should be submitted to the core anyways.

[ockham]

Maybe we should start removing unit tests for APIs that are part of WP core since updates should be submitted to the core anyways.

Yeah, that's the strategy we've followed elsewhere, e.g. #36855

[Mamaduka]

Thanks for the confirmation, @ockham.

Let's merge this PR since it also contains updates for the actual REST controller and will be helpful for WP 5.8.

We can remove the unit test in a separate PR.

[ramonjd]

The plugin has to support older versions of WP, and this is the new API available in 5.9. The WP_REST_URL_Details_Controller class is conditionally loaded. This and unit tests being out of sync is also the reason for test failures.

Thanks for the context and for testing @Mamaduka !! 🙇

I can't merge until the other tests pass, so I'll try to hunt down an admin to merge this since the PHP unit test fails are probably blocking any PRs that attempt to fix the other tests 😅