Spacer: Fix unit settings filter #37774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Spacer
Mamaduka
commented
Jan 7, 2022
| ); | ||
| const availableUnitSettings = ( | ||
| useSetting( 'spacing.units' ) || undefined | ||
| )?.filter( ( availableUnit ) => availableUnit !== '%' ); |
There was a problem hiding this comment.
We need to use undefined and optional changing to apply defaults below.
|
Size Change: +14 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
11 tasks
29 tasks
fullofcaffeine
pushed a commit
that referenced
this pull request
Jan 10, 2022
Mamaduka
added
the
Backport to WP Minor Release
|
Should be backported with #36186. |
Mamaduka
removed
the
Backport to WP Minor Release
Mamaduka
added a commit
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #37758.
The
useSetting( 'spacing.units' )can returnfalse, which isn't filterable.How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).