[Block Library - Query Loop]: Reorganise inspector controls + order selection bug
#37949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
aristath,
gziolo,
michalczaplinski and
cbravobernal
|
Size Change: +158 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
cbravobernal
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first iteration of
Query Loopblock seems to have worked well but there is so much more to be improved. I plan to create a new overview issue about the next steps for this soon.For start I want to decouple the block from
QueryControlscomponent which was first implemented forLatest Postsblock. This PR though handles only theorder/orderBy, because I intent to also implement multiple authors selection right after.The change of folder structure is needed and will become more obvious with the follow up PRs.
By doing this I noticed an existing bug in
order/orderBywhen the new selection included a change in bothorderandorderByattributes. In that cases we would issue two changes in the same top levelqueryattribute(object) and because updates are batched after the render, changes in different query properties would cause to override previous wanted changes.Before
before.mov
After
after.mov
Testing instructions
orderoptions