[Block Library - Query Loop]: Add multiple authors support #38024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
Mamaduka,
youknowriad,
aristath,
gziolo,
kjellr,
carolinan and
cbravobernal
ntsekouras
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +120 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ntsekouras
commented
Jan 17, 2022
cbravobernal
approved these changes
Jan 17, 2022
aristath
approved these changes
Jan 17, 2022
|
Thanks for the reviews! I'll not merge yet, as an important change is included at the building step of Gutenberg and wasn't there at the time of the reviews. If the above change is okay, the rest already tested functionality had no other changes, so we'll be good to merge. |
ntsekouras
force-pushed
the
add/multiple-authors-in-query-loop
branch
from
e888012 to
f8843e1
Compare
|
I'm merging this one, but noting that an alternative approach about the change in the building step would be:
This would be also needed if we ever want to make block supports code also automatically backported. Thanks @youknowriad for the feedback/discussion about all these! |
20 tasks
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26668
This PR adds support for filtering a
Query Loopwith multiple authors instead of just one, which is the current behavior.Follow up of: #37949
In addition
QueryControlscomponent usage is now removed completely.Testing instructions
webpackconfig.Query Loopwhether we had set anauthorfilter to the block or not.Notes
This PR includes one more change that affects the building step of the plugin.
We need to automatically rename some functions when they are called inside block files, but have been declared elsewhere. This way we can call Gutenberg override functions, but the block will still call the core function when updates are back ported. Specifically we do it now for
build_query_vars_from_query_block, but this could be used with other similar functions with the same use case.