-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a block supports chapter to the block creation tutorial #38210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good first step, let's ship and iterate.
Once a few more pieces are in place: #38208, other tutorials (block supports for dynamic blocks), code in new code in https://github.com/WordPress/gutenberg-examples, etc we should review all the content together and polish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy looks good to me.
I don't see this page in the block tutorial and the link introduced in the previous chapter points to a non-existing page. I've prepared #38452 to fix this. |
I inadvertently committed (now reverted) this tutorial in trunk.
The idea is that we emphasize custom controls a bit too much while most block authors should ideally rely on block supports.