Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the block supports for static blocks tutorial in the handbook #38452

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Show the block supports for static blocks tutorial in the handbook #38452

merged 3 commits into from
Feb 3, 2022

Conversation

oandregal
Copy link
Member

Follow up to #38210

This PR aims to fix two issues:

  • The link at the end of the block controls section points to a non-existing page. I believe this is because it's relative and not absolute (docs/... vs `/docs/...).
  • The page doesn't show up in the block tutorial sidebar. I believe this has to do with another page having the same slug (block supports). This PR changes the slug so it's unique.

@oandregal oandregal self-assigned this Feb 2, 2022
@oandregal oandregal added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers labels Feb 2, 2022
@oandregal oandregal mentioned this pull request Feb 2, 2022
Merged
@oandregal oandregal requested a review from ryanwelcher February 2, 2022 14:17
ntsekouras
ntsekouras approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oandregal !

@oandregal @ntsekouras
Update docs/how-to-guides/block-tutorial/block-controls-toolbar-and-s…
0102a37 
…idebar.md

Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
@oandregal oandregal merged commit 715340b into trunk Feb 3, 2022
@oandregal oandregal deleted the fix/tutorial-block-supports-static-blocks branch February 3, 2022 09:13
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 3, 2022
@oandregal
Copy link
Member Author

This has moved things forward: the page is now listed in the sidebar and accessible via this URL https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/block-supports-in-static-blocks/

However, the content is missing 🤔

@oandregal
Copy link
Member Author

Asking in slack's core-editor for advice.

@oandregal
Copy link
Member Author

And now, it magically works 🪄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@youknowriad youknowriad Awaiting requested review from youknowriad

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @ntsekouras