Don't try to parse strings that don't contain blocks #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
added
[Type] Performance
mtias
reviewed
Dec 11, 2017
lib/blocks.php
Outdated
| * If there are no blocks in the content, return a single block, rather | ||
| * than wasting time trying to parse the string. | ||
| */ | ||
| if ( ! preg_match( '/<!--\s*(wp:|more|noteaser)/', $content ) ) { |
There was a problem hiding this comment.
Can we use gutenberg_content_has_blocks() here?
youknowriad
force-pushed
the
fix/3799-parse-oom
branch
from
227aaf8
to
357f409
Compare
This was referenced Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in #3799, parsing long strings that don't contain blocks cause significantly increased memory usage.
As ~100% of posts published prior to the release of WordPresss 5.0 fit this description, it's worth adding a special case to bail early, before even trying to parse the unparseable.
How Has This Been Tested?
Creating a post in the classic editor with this sample data, viewing the post, and observing memory usage under different conditions:
With Gutenberg disabled: 4.5MB, ~0.1s
With Gutenberg
masterenabled: 46.1MB, ~0.3sWith this PR enabled: 4.6MB, ~0.1s
Checklist: