Upgrade Playwright and use the official role selector engine #41389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
@playwright/testto v1.22.2 and use the official role selector engine.Why?
We're currently using a community version (by me) of the role selector engine since the official engine wasn't stable yet. Now that the official engine is stable, we can swap out
role-selectorand use the official one.How?
By upgrading
@playwright/testand removing theselectors.registercode we have. Amazingly, no other code has to be changed for this migration, proving thatrole-selectorwas a good enough polyfill ;).Testing Instructions
CI should pass.